ci(sync): update GitHub Actions - #117
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Sync all required dependency groups, including development dependencies, before scanning.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates the Trivy license-report workflow to support uv-managed environments.
Changes:
- Detects
uv.lockfiles. - Runs frozen
uvsynchronization before scanning.
File summaries
| File | Summary |
|---|---|
.github/actions/trivy-license/script.sh |
Adds uv dependency synchronization for license discovery. Review note: --no-dev omits development dependency groups, making the report incomplete. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| while IFS= read -r -d '' uv_lock; do | ||
| uv_dir="$(dirname "${uv_lock}")" | ||
| echo "uv.lock found in ${uv_dir#"${REPO_ROOT}"/}, running 'uv sync --frozen --no-dev'..." | ||
| (cd "${uv_dir}" && uv sync --frozen --no-dev) || echo "warning: 'uv sync' failed in ${uv_dir}, uv license detection may be incomplete" >&2 |
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ik-ci-admin
Bot
force-pushed
the
ci/sync-github-actions-19df5ad
branch
from
September 16, 2026 20:19
25d9495 to
6c0b561
Compare
alexpriv8
approved these changes
Sep 16, 2026
There was a problem hiding this comment.
🔵 Needs a closer look
The license scan may produce incomplete reports by excluding the default development dependency group.
Review details
Suppressed comments (1)
.github/actions/trivy-license/script.sh:144
--no-devremoves uv's defaultdevdependency group from the in-project environment. That makes the generated report omit licenses for development tools, unlike the existing Pipenv path (pipenv sync --dev) and Yarn path, so projects whose relevant packages are in the dev group can produce incomplete reports. Please sync the default dev group here (for example, useuv sync --frozenwithout--no-dev).
echo "uv.lock found in ${uv_dir#"${REPO_ROOT}"/}, running 'uv sync --frozen --no-dev'..."
(cd "${uv_dir}" && uv sync --frozen --no-dev) || echo "warning: 'uv sync' failed in ${uv_dir}, uv license detection may be incomplete" >&2
- Files reviewed: 3/3 changed files
- Comments generated: 0 new
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically generated PR to sync GitHub Actions and related configs.