Skip to content

chore!: rm unused argument in layout_with_mds() - #2869

Open
maelle wants to merge 2 commits into
mainfrom
nooptions
Open

chore!: rm unused argument in layout_with_mds()#2869
maelle wants to merge 2 commits into
mainfrom
nooptions

Conversation

@maelle

@maelle maelle commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Fix #2730

@github-actions

Copy link
Copy Markdown
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if b9c764b is merged into main:

  • ✔️as_adjacency_matrix: 810ms -> 819ms [-0.89%, +2.96%]
  • ✔️as_biadjacency_matrix: 807ms -> 803ms [-2.7%, +1.61%]
  • ✔️as_data_frame_both: 1.77ms -> 1.75ms [-4.51%, +2.39%]
  • ✔️as_long_data_frame: 4.44ms -> 4.4ms [-4.26%, +2.55%]
  • ✔️es_attr_filter: 2.76ms -> 2.8ms [-1.13%, +4.17%]
  • ✔️graph_from_adjacency_matrix: 133ms -> 135ms [-2.33%, +5.66%]
  • ✔️graph_from_data_frame: 4.04ms -> 3.99ms [-3.92%, +1.68%]
  • 🚀vs_attr_filter: 1.58ms -> 1.56ms [-3.26%, -0.14%]
  • ✔️vs_by_name: 1.09ms -> 1.06ms [-7.19%, +2.11%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@krlmlr

krlmlr commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Looks good. Agreed to remove the redundant parts that are already in _impl() .

@maelle
maelle requested a review from schochastics September 3, 2026 11:02
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 9064ec7 is merged into main:

  • ✔️as_adjacency_matrix: 853ms -> 849ms [-2.95%, +2.09%]
  • ✔️as_biadjacency_matrix: 883ms -> 880ms [-2.23%, +1.52%]
  • ✔️as_data_frame_both: 1.69ms -> 1.7ms [-1.07%, +2.48%]
  • ✔️as_long_data_frame: 4.18ms -> 4.13ms [-2.71%, +0.53%]
  • ✔️es_attr_filter: 3.02ms -> 2.94ms [-5.02%, +0.15%]
  • ✔️graph_from_adjacency_matrix: 170ms -> 167ms [-7.24%, +3.89%]
  • ✔️graph_from_data_frame: 3.82ms -> 3.86ms [-0.57%, +2.31%]
  • ✔️vs_attr_filter: 1.72ms -> 1.74ms [-1.82%, +4.25%]
  • ✔️vs_by_name: 1.21ms -> 1.15ms [-12.28%, +2.2%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@schochastics schochastics left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

layout_with_mds() unused options argument

3 participants