fix(vue): build on prepack so publish ships a fresh dist - #49
Merged
Merged
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Releases have been bumping
@interchain-kit/vuewithout putting it on npm: tags exist for 0.10.2, 0.11.0 and 0.11.1, but npm'slatestis still 0.10.1 (Apr 8). Every other package has"prepack": "npm run build", and@interchain-kit/vuedidn't. Because ofpublishConfig.directory: "dist",lerna publishuploads whatever is indist/, and nothing rebuilds it first. So the vue package either fails to publish or would ship an old build."build": "vite build && copyfiles -f ../../LICENSE README.md package.json dist", + "prepack": "npm run build",Checked locally:
npm run prepackin packages/vue runs the vite build and writesdist/package.jsonat 0.11.1.After merging,
lerna publish from-packageuploads the missing@interchain-kit/vue@0.11.1, which has the WalletManagerStore port from #48. It skips everything that's already on npm.Link to Devin session: https://app.devin.ai/sessions/a02c84f654b94cbcb50936e98373fba5
Open in Devin Desktop: https://app.devin.ai/desktop/session/a02c84f654b94cbcb50936e98373fba5?variant=devin
Requested by: @pyramation