fix(ghostty): use Ghostty's bundled iTerm2 Solarized, drop vendored themes - #76
Open
catinspace-au wants to merge 1 commit into
Open
catinspace-au wants to merge 1 commit into
catinspace-au wants to merge 1 commit into
Conversation
…hemes Vendored theme files only resolve from the XDG themes dir. macOS reads its config from ~/Library/Application Support/com.mitchellh.ghostty/ but resolves a bare theme name only from ~/.config/ghostty/themes/ and the app bundle, so themes deployed beside the macOS config were never found and Ghostty silently fell back to its default dark theme. Switch to the iTerm2 Solarized pair that ships inside Ghostty itself on both platforms (app bundle on macOS, /usr/share/ghostty/themes owned by the ghostty package on Linux). No OS package, nothing vendored. The bundled variant is also strictly better: canonical Solarized sets ANSI 8 to the exact dark background (invisible bright-black) and ANSI 7 too close to the light background. The iTerm2 variant lifts both off. Also fixes the Linux heal task, which matched the new theme line and would have reverted it to the vendored names on every run, and removes the now-dead vendored files from existing installs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vendored theme files only resolve from the XDG themes dir. macOS reads its config from
~/Library/Application Support/com.mitchellh.ghostty/but resolves a bare theme name only from~/.config/ghostty/themes/and the app bundle, so themes deployed beside the macOS config were never found and Ghostty silently fell back to its default dark theme.Switches to the iTerm2 Solarized pair that ships inside Ghostty itself on both platforms (app bundle on macOS,
/usr/share/ghostty/themesowned by theghosttypackage on Linux, verified withdpkg -S). No OS package, nothing vendored. Ghostty has no system-wide config path, so this stays per-user by design.The bundled variant is also strictly better: canonical Solarized sets ANSI 8 to the exact dark background (invisible bright-black) and ANSI 7 too close to the light background. The iTerm2 variant lifts both off (#335e69 / #bbb5a2) and is otherwise identical.
Also fixes the Linux heal task, which matched the new theme line and would have reverted it to the vendored names on every run.
Verification
ansible-lintpasses (production profile);yamllinterrors reduced 3 -> 2, both pre-existingghostty +validate-configsilent with nothing vendored left, background measured #002a36 = Solarized Dark