Skip to content

Install the shard map on join before region movement - #114

Closed
austin-barrington wants to merge 1 commit into
feat/sharding-n1-legal-clusterfrom
feat/sharding-joiner-map-catchup
Closed

austin-barrington wants to merge 1 commit into
feat/sharding-n1-legal-clusterfrom
feat/sharding-joiner-map-catchup

Conversation

@austin-barrington

Copy link
Copy Markdown
Member

Stacked on #113.

Summary

  • A joining node installs the committed shard map (GET /internal/shard/map + replace_map) during join/reconnect, after metadata and before any region data movement.
  • Scheduler helpers refuse movement until the joiner's map_version equals the cluster's. Catch-up does not add the joiner as a peer.

Test plan

  • cargo test --lib (includes replace_map_installs_peer_snapshot, joiner_map_catchup_blocks_movement_until_versions_match)
  • cargo test --test sharding_cluster_integration joiner_map_version_matches_before_region_movement
  • cargo test --test sharding_cluster_integration --test sharding_integration --test sharding_failover_integration --test sharding_mv_integration
  • cargo fmt --check and cargo clippy --all-targets -- -D warnings

Made with Cursor

A joiner's map_version must match the cluster's before any peer-set change, so staging cannot run against a lagging epoch.
@cursor

cursor Bot commented Sep 4, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_ba36ae2f-978a-43a3-9ee1-637d87510e77)

@austin-barrington

Copy link
Copy Markdown
Member Author

Superseded by #115, which contains this commit as part of the full Phase 1 branch (verified: this head is an ancestor of #115). Closing unmerged — merging both would apply the same change twice, since a squash-merge here creates a new commit on main while #115 still carries the original.

@austin-barrington
austin-barrington deleted the feat/sharding-joiner-map-catchup branch September 7, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant