Repository navigation
fix(sample): read the demo's p95 tile off the demo's latency curve - #80
Merged
Merged
Conversation
In sample mode the p95 tile printed 88 ms beside a curve ending in the 40s. Both are generated, but on a real platform the two are one number since #79, and a demo that shows them disagreeing teaches the wrong thing about the screen. - mockSummary takes the sample series and reports its newest point as the p95, and the change from the point one window back as the trend - A scenario pins it: the cold-start demo's tile equals the chart's newest point. Put the fixed 88 back and it fails Tags: #sample #honesty Co-Authored-By: htjulia <htjulia1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #79 (#78).
Why
In sample mode the p95 tile showed 88 ms next to a latency curve ending in the 40s. Both values are generated. Since #79, though, a real platform always shows the tile and the chart's newest point as the same number. A demo where they disagree misrepresents what the two panels mean.
What
mockSummarynow takes the sample latency series. It reports the series' newest point asp95LatencyMs. It reports the change from the point onewindowMsearlier asp95DeltaMs, which is the comparison a platform makes.Verification
88put back, this test fails.45ms, the newest point sits at the 45 ms height (cy=53on the 0–60 axis), and the sub-line reads4ms · p99 210ms.