Repository navigation
docs(auth): correct four claims the code no longer backs - #75
Merged
Merged
Conversation
docs/authentication.md is the public guide an operator follows to wire auth into the console. Four of its statements describe code that is not there, or leave out a condition, so following them would not work. - REST is not a fallback. The guide named fetchSnapshot as the REST fallback that shares getJson with the module-routes drawer, but nothing calls fetchSnapshot (its only reference is its declaration). The drawer is the only REST call; the diagram now starts there and a note says what fetchSnapshot is - The 401/403 surface is not already half wired. The guide said fetchSnapshot classifies auth responses for the top bar to reuse. The top bar and banner do render AUTH REQUIRED / AUTH REJECTED, but no path produces the auth reason: the stream reports every failure as unreachable and the drawer shows "Failed to load routes." - The dev proxy note is true but dev-only. vite build has no proxy, so a production bundle sends /platform to its own origin; the guide now says so and how to keep the same-origin cookie path - Cross-origin cookies need SameSite=None; Secure, so they require the platform over HTTPS. The recommended cookie scheme did not say that The guide stays in English: it is a public operator guide, like the README, and is kept as an exception to the Korean docs/ default. Tags: #docs #auth Co-Authored-By: htjulia <htjulia1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
docs/authentication.mdis the public guide an operator follows to wire auth into the console. Four of its statements describe code that is not there, or leave out a condition, so following them would not work.What
fetchSnapshotfetchSnapshothas no callers; the module-routes drawer is the only REST callgetModuleRoutes; a note says whatfetchSnapshotisfetchSnapshotalready classifiesauthresponses; the top bar reuses…"AUTH REQUIRED/AUTH REJECTED, but nothing produces theauthreason: the stream always reportsunreachable, the drawer shows "Failed to load routes."npm run dev;vite buildhas no proxywithCredentials+ CORS credentialsSameSite=None; Secure, so HTTPS1 and 2 were false. 3 was incomplete in scope, and 4 left out a condition. Neither was wrong.
The guide stays in English. It is a public operator guide, like the README, and is kept as an exception to the repo's Korean
docs/default.fetchSnapshotitself is not removed here. Its removal is tracked separately with the REST surface work.