Repository navigation
fix(chart): label the sample latency curve as sample data - #74
Merged
Merged
Conversation
With no platform reachable the console fills every card with generated data and the top bar says SAMPLE DATA. The latency chart was the one card that made a claim of its own on top of that: its header read "ms · rolling window", which a generated curve is not. - LatencyChart takes a sample flag; App sets it from conn.status. The header then reads "ms · sample data" and the aria-label says the values are generated - The curve stays: every other card shows sample values as well, so an empty chart would single this one out without making the screen more honest, and the demo would lose the card people explore first - Three tests cover the label, the curve, and the label going away once real samples arrive. With the component change reverted, the label test fails - Checked in the browser against a dev server with no platform: badge SAMPLE DATA, header "ms · sample data", polyline drawn - Gates: lint clean (same 7 warnings as main), 202 tests pass Tags: #chart #honesty Co-Authored-By: htjulia <htjulia1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
With no platform reachable, the console fills every card with generated data and the top bar says
SAMPLE DATA. The latency chart was the one card that made a claim of its own on top of that: its header readms · rolling window, which a generated curve is not.What
LatencyCharttakes asampleflag.Appsets it fromconn.status === 'sample'.ms · sample dataand thearia-labelsays the values are generated.Verification
SAMPLE DATA, headerms · sample data,aria-label"p95 latency, generated sample data", polyline drawn.npm run lint: 7 warnings, the same set asmainnpm test: 17 files, 202 tests pass