Repository navigation
chore(deps): drop unused dep and unship the cli - #42
Merged
Merged
Conversation
- `@shadcn/react` 0.3.0 was never imported: the `base-nova` components in src/components/ui all import `@base-ui/react` subpaths, so the package had no role now and none coming from future `shadcn add` either - `shadcn` is a CLI, not a runtime import — as a production dependency it was shipped in the prod tree and picked up by dependabot's production group on every release, so it moves to devDependencies - the reinstall refreshes 30 transitive versions inside the CLI's own (now dev-only) tree; among them js-yaml 4.3.0 -> 4.3.1, which is the patched release for GHSA-5p4m-2wfm-xmqj, so npm audit reports 0 vulnerabilities in both scopes - the app bundle is byte-identical and the runtime tree keeps all 14 packages it actually imports Tags: #deps Co-Authored-By: htjulia <htjulia1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acts on a finding recorded in the brain on 2026-08-09 that was never applied:
@shadcn/reactis unused, and theshadcnCLI sits independencieswhere it does not belong.Changes
@shadcn/react0.3.0dependenciessrcshadcn4.18.0dependenciesdevDependencies@shadcn/reactis not a latent need either: this project's style isbase-nova, and all 12 files insrc/components/ui/import@base-ui/reactsubpaths (@base-ui/react/button,/select,/tabs, …) —@shadcn/reactappears nowhere, so a futureshadcn addwill not want it back.Effect on
npm audit: 1 high → 0 in both scopesWorth being precise about the mechanism, because it is not the dependency move:
shadcnunderdevDependenciesre-resolved its own subtree and pulledjs-yaml4.3.0 → 4.3.1GHSA-5p4m-2wfm-xmqj(advisory: vulnerable>= 4.0.0, < 4.3.1, first patched4.3.1), reached throughcosmiconfig's^4.1.0rangemainwould have cleared it tooWhat the move itself buys is scope correctness: a CLI is no longer in the production tree, and dependabot stops proposing it in the production group on every release (that PR noise is the other half of the 2026-08-09 finding).
Lockfile scope
@shadcn/reactcontent-type2.1.0,powershell-utils0.1.0 — both nested inside the CLI's dev-only treeshadcn's own subtree (babel 7.29.7→7.29.8, hono 4.13.0→4.13.3, jose 6.2.4→6.2.10, js-yaml 4.3.0→4.3.1, wsl-utils 0.3.1→1.0.0, browserslist/caniuse data, …). Same category as chore(deps): refresh transitive deps to clear npm audit #30's transitive refreshreact,react-dom,@base-ui/react,@tanstack/react-virtual,lucide-react,idb,clsx,cva,tailwind-merge,tailwindcss,@tailwindcss/vite,tw-animate-css, both@fontsource-variable/*) are untouchedVerification
npm run lint— exit 0, 3 warnings (unchanged)npm run build— exit 0, anddist/assets/index-*.js/index-*.cssare byte-identical tomain(5538909255…/de51a9a3ab…), which is the expected result of removing something nothing importednpm auditandnpm audit --omit=dev— found 0 vulnerabilities (was 1 high in both)npx shadcn --version→4.18.0, soshadcn addstill works fromdevDependenciesnpm run dev— Vite 8.2.1 boots,http://localhost:5173/returns 200Observation, not addressed here
tailwindcss,@tailwindcss/viteandtw-animate-cssare also build-time-only independencies. Nothing consumes this package as a library, so the classification has no practical effect — left alone rather than widening this PR.