fix: carry trusted provenance across cell HTTP - #245
Open
patrickleet wants to merge 4 commits into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
An authenticated cell-command producer needs a small, explicit provenance context to survive the HTTP wait path so the receiving cell can validate source, operation, and decision identity. Forwarding the whole session would preserve too much unbounded, spoofable state; dropping provenance silently loses the authorization boundary.
Context example
Summary
CellRequestContextfor internal cell wait-path callsSessionclaimsAggregateCelldispatch, causation preservation, replay, secret/provenance rejection, and command-body reuse fencingValidation
cargo test --features graphql,http command_dispatch::host::tests --lib— 5 passedcargo test --features graphql,http --test causal_wait_path --quiet— 10 passedcargo test --features graphql,http --lib --quiet— 941 passed