fix: hand off older query graphs to live subscriptions - #241
Open
patrickleet wants to merge 2 commits into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A live query could remain empty after successful SSR hydration even while the server delivered new rows. If one of those rows referenced a relationship already seeded by another query (for example, a layout), the replica rejected the entire incoming graph as incomparable. The subscription stayed active and reported no query error, leaving the page stuck until reload.
What changes
Record a local subscription-start fence. Snapshot delivery may take over relationships owned by queries that preceded that subscription. It still cannot overwrite an independently active live stream or query ownership acquired after it started. Server causal vectors, record clocks, authorization fences, and disposal fencing remain unchanged.
For example, a page can start with an empty list, then receive a newly created item referencing an owner already loaded by its layout. The item now appears through the existing subscription without polling or reloading.
Validation
No user-facing UI copy is added. Documentation describes the handoff and its limits.
Stacked on #240 so it uses the same tested v5 runtime baseline; this PR contains only the subscription handoff fix.