Shouldly assertions in tests, shared TargetFrameworks in Directory.Build.props - #3
Merged
Merged
Conversation
LibraryTargetFrameworks (net8.0;net9.0;net10.0) is defined once and referenced by the two libraries and the test project, same layout as AutoPoco. Benchmarks stay net10.0 only. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
All 21 test classes use Shouldly instead of xunit Assert. Shouldly and Xunit are global usings in the test project. String containment checks pass Case.Sensitive explicitly because Shouldly defaults to case-insensitive, unlike xunit. Test classes and nested argument classes are sealed where nothing derives from them. Test names, order and asserted values are unchanged; 313 tests per target framework, same as before. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code cosmetics only, no behavior change in the libraries and no release.
Changes
Assert.*in all 21 test classes (about 760 assertions).ShouldlyandXunitare global usings in the test csproj.Case.Sensitiveexplicitly: Shouldly'sShouldContain/ShouldStartWithon strings are case-insensitive by default, xunit's are not. Verified against Shouldly 4.3.0.sealedwhere nothing derives from them.LibraryTargetFrameworks(net8.0;net9.0;net10.0) is defined once in Directory.Build.props and referenced by the two libraries and the test project, same layout as AutoPoco. Benchmarks stay net10.0 only.Verification
Should.Throw<T>accepting derived exception types whereAssert.Throws<T>required the exact type.🤖 Generated with Claude Code