ci: add an ok aggregator as the single required status check - #27
Merged
Conversation
Branch protection should require one stable context, not a list of job names that changes whenever CI does. Every new job goes in `needs:` here instead of in repository settings. It requires SUCCESS rather than testing for failure. `contains(needs.*.result, 'failure')` does not match 'skipped', so an `if: false` on a real job yields a fully green pull request with nothing checked -- measured in a sibling repo, where it produced exactly that. This workflow has no path filtering, so nothing here skips legitimately; a repo that does filter needs the tolerant form instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings this repo in line with the org's CI shape: one
okjob that every other job feeds, so branch protection requires a single stable context and CI can evolve without touching repository settings.It requires success rather than testing for failure. The usual spelling is
contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled')— which does not match'skipped'. Anif: falseon a real job therefore produces a fully green pull request with nothing checked. That was measured in a sibling repo, not reasoned about.The tolerant form is correct where a workflow uses path filtering and jobs skip legitimately on docs-only changes. This workflow has no path filtering, so a skipped job here is always a defect, and the strict form is the right one.