This repository was archived by the owner on Sep 1, 2026. It is now read-only.
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Commented-out Hatch build configuration is likely to produce unusable wheels (missing python_mscl.mscl) and break the existing install/import verification flow.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Archives the python-mscl project by adding prominent archive messaging and an import-time deprecation warning, while also updating packaging metadata to newer Python versions.
Changes:
- Emit an import-time warning in
python_mscldirecting users to the officialpymsclpackage. - Update project metadata/lockfile to require Python >=3.11 and bump the package version.
- Add an “ARCHIVED” notice to the README and update local Python version pin.
File summaries
| File | Description |
|---|---|
uv.lock |
Updates lock metadata for Python >=3.11 and bumps lock revision/package version. |
src/python_mscl/__init__.py |
Emits an archive/deprecation warning on import and comments out prior export behavior. |
README.md |
Adds an archive notice pointing users to pymscl. |
pyproject.toml |
Bumps version, requires Python >=3.11, updates classifiers/ruff target, and comments out Hatch wheel/hook config. |
.python-version |
Changes the pinned local Python version string. |
Review details
- Files reviewed: 4/5 changed files
- Comments generated: 4
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
11
to
+13
| # Intentionally make the user can do `from python_mscl import mscl` instead of `import mscl` which | ||
| # can be done by doing a from .mscl import * here. | ||
| __all__ = ["mscl"] | ||
| # __all__ = ["mscl"] |
Comment on lines
+31
to
+35
| # [tool.hatch.build.targets.wheel] | ||
| # packages = ["src/python_mscl"] | ||
|
|
||
| [tool.hatch.build.hooks.custom] | ||
| path = "hatch_build.py" | ||
| # [tool.hatch.build.hooks.custom] | ||
| # path = "hatch_build.py" |
Comment on lines
7
to
10
| { name = "Harshil", email = "37377066+harshil21@users.noreply.github.com" } | ||
| ] | ||
| requires-python = ">=3.9" | ||
| requires-python = ">=3.11" | ||
| classifiers = [ |
Comment on lines
1
to
+4
| # python-mscl | ||
|
|
||
| # ARCHIVED: There is now an official mscl library: [`pymscl`](https://pypi.org/project/pymscl). Please use that library instead. | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is now an official pymscl library, and I was contacted by them to take it down.