chore: back-merge main into dev (reconcile post-split trunk hotfixes) - #1234
jeonghun-jj-lee wants to merge 1 commit into
Conversation
The dev/main split (2026-09-15) left main carrying fixes that never reached the integration branch, because they were merged straight to main after the split. This back-merge brings them into dev so the branches share history and the next dev->main Wave is a clean fast-forward. Brought in from main: #1209 Bedrock cachePoint-after-reasoning session wedge (the Diraq-ESR crash) #1218 drop empty-content messages before API dispatch 568306f convert unsignable Bedrock reasoning to text #1207 omit-agent promptAsync continues current agent #1179 stop assistant prefill for max-steps prompt #1158 Slack MCP via slack-mcp-server + OAuth PKCE #1174 lineage repair + diff_version propagation #1200 harden adoption gate + rebuild status delivery (content already in dev) Conflict resolution (3 files, all mechanical): transform.ts, transform.test.ts — taken from main. dev held stale #1209-era snapshots dragged in incidentally by #1220; main is strictly ahead (#1218 + 568306f). Verified byte-identical to origin/main post-resolve. manifest.json — regenerated from the merged overlay via refresh_manifest.mjs (826 files = dev's #1203 registrations + main's transform). Verified with drift_gate.mjs (PASS). Not a blind take-theirs: that would have dropped the #1203 overlay registrations dev added in 22c45c1. Merge commit is intentional — do NOT squash (squashing re-orphans main's history from dev and re-breaks the next Wave).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe provider transform now preserves unsigned Bedrock reasoning text as text, removes empty message content, and adds tests for these cases. The overlay manifest records the changed provider files and newly included app files. ChangesProvider message normalization
Overlay manifest regeneration
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Description checkExplanation The description gives detailed context, lists the imported commits, documents conflict resolution, explains the merge strategy, and records verification results. It does not include the required Related Issue link or the Type of Change selection from the repository template. Resolution Add a Related Issue section with a valid GitHub issue reference, such as Full details: Docstring CoverageExplanation Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
⚔️ Resolve merge conflicts 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Superseded by Aaron's parallel wave-2 back-merge (
|
Summary
Back-merge
mainintodevto reconcile the drift left by thedev/mainsplit (2026-09-15, ADR-0021). Several fixes were merged straight tomainafter the split — the reverse of the intendeddev→mainWave flow — so the integration branch never received them. This merge brings them in and re-establishes shared history, so the nextdev→mainWave is a clean fast-forward.What this brings into
dev(8 commits, all previouslymain-only)568306f8— convert unsignable Bedrock reasoning to text before the SDK adapter drops itpromptAsynccontinues the session's current agentslack-mcp-server+ OAuth PKCE logindiff_versionpropagationdevvia docs: ADR 0021 — research layout is a resolved contract #1220's drag; the merge just reconciles history)The Bedrock cluster (#1179/#1207/#1209/#1218/
568306f8) matters most:devis the default/integration branch, so without this, daily-driver builds offdevstill hit the session-wedge crash.Conflict resolution (3 files — all mechanical)
…/provider/transform.tsmain's versiondevheld a stale#1209-era snapshot dragged in incidentally by #1220;mainis strictly ahead (#1218+568306f8). Verified byte-identical toorigin/mainpost-resolve.…/test/provider/transform.test.tsmain's versionmain.packages/app-bundle/manifest.jsonrefresh_manifest.mjsmain: that would have dropped the 8#1203overlay registrationsdevadded in22c45c16. Regenerated from the merged overlay tree (826 files =dev's#1203files +main's transform), then verified withdrift_gate.mjs.Verification (local, before request)
drift_gate.mjs— PASS (826 overlay files verified against the manifest; transform hash matchesmain)pnpm -r build— clean (extension + amico-run + overlay artifacts)pnpm --filter amicode test— 229 files, 3594 passed / 39 skipped, 0 failedorigin/mainis now an ancestor of the merge (0main-only commits remain); the dev-only canary/CI/fleet commits (ADR-0021: the canary — fleet arms, CI artifacts, daily-driver excluded (+ glossary) #1197, ci: run on dev pushes — the canary's blessed-SHA gate needs CI at the integration tip #1201, build:app pre-flight compares against origin/main — should follow the default branch (dev workflow) #1196, fleet projection publish never passes --topology — every verb run clobbers enrolled machines to standalone #1194/fix(fleet): pass --topology to the projection publish (#1194) #1195, the fleet client poll needs hysteresis — one lost probe flips fleetReady and offers standalone at 10s #1202, the session view must survive transient SSE loss — keep the rendered state, show a reconnecting badge #1203) are all intact.This is an intentional merge commit (two parents:
devtip +maintip). Squashing would collapsemain's history into a new SHA, re-orphaning it fromdevand re-breaking the next Wave — the exact drift this PR fixes. Use "Create a merge commit" (or fast-forward), not squash.Summary by CodeRabbit