docs(adr): ADR 0020 — standalone server survives an editor reload (#1142) - #1143
Merged
Merged
Conversation
) Record the design-of-record for making a window reload non-destructive to the standalone chat server: detached spawn, adopt-on-handshake, grace-window + active-work pin, and one engine-side self-shutdown timer. Amends ADR 0002 (per-boot password persisted 0600 for adoption), relates to ADR 0005 (the standalone sibling of the Canonical Server), extends ADR 0018 (the Rebuild reload becomes non-fatal). Adds the CONTEXT.md serving terms: Server handshake, Server adoption, Active-work pin, Grace window; refines standalone.
|
Warning Review limit reachedNext included review available in 3 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Renumber 0019 -> 0020: ordinal 0019 was taken on main by 0019-overlay-provenance-naming.md after this branch was cut. - Admit Stop as a second deliberate kill alongside Restart (blocking contradiction from the sub-issue deliberation); grace self-exit is the only non-deliberate stop. - Pin grace default (30 s) + key amicode.server.graceSeconds. - Define protocolVersion compatibility as exact match. - 'keeps the server alive' not 'pinned' (glossary reserves pin for turns). - Reframe ADR 0018 relation: 0018 covers rebuild modes, not reload fatality; that non-fatality is this ADR's new property.
jeonghun-jj-lee
changed the title
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design-of-record for #1142.
Records ADR 0019 and the
CONTEXT.mdserving-vocabulary deltas for making a VS Code window reload non-destructive to the standalone chat server, so in-flight agent turns keep running through a rebuild.Decision. Detached spawn + adopt-on-handshake, grace-window + active-work pin, and one engine-side self-shutdown timer driven by an authenticated keepalive. The engine already keeps a turn's forked fiber alive across a client disconnect and persists in-flight state durably, so the feature reduces to keeping the process alive and reconnecting.
Cross-links. Amends ADR 0002 (per-boot password now persisted
0600for adoption) · relates to ADR 0005 (the standalone sibling of the launchd Canonical Server) · extends ADR 0018 (the Rebuild reload becomes non-fatal; stale-engine restart UX; skip the binary build when the overlay is unchanged).Glossary. Refines
standalone; adds Server handshake, Server adoption, Active-work pin, Grace window.Docs only — no code in this PR. Implementation lands via the sub-issues decomposed from #1142.
Source:
docs/adr/0019-standalone-server-survives-reload.md