Skip to content

chore(#1118): sweep residual fork vocabulary from provisioning + naming - #1141

Merged
jeonghun-jj-lee merged 1 commit into
mainfrom
jj/1118-fork-vocabulary-sweep
Sep 14, 2026
Merged

jeonghun-jj-lee merged 1 commit into
mainfrom
jj/1118-fork-vocabulary-sweep

Conversation

@jeonghun-jj-lee

Copy link
Copy Markdown
Contributor

Closes #1118. The final closure of #1091's "no source references harmoniqs/opencode" criterion, now that v0.3.6-alpha.1 validated the overlay-build binary end-to-end (release.yml run 34855247762).

Designed via grill-with-docs; decision recorded in docs/adr/0019-overlay-provenance-naming.md. Design-of-record: issue #1118 body.

Three independent clusters

A. Manifest provenance rename (atomic). packages/app-bundle/manifest.json: fork_ref/fork_tag/fork_shaoverlay_ref/overlay_tag/overlay_sha, scope reworded fork-agnostic, schema 5→6. Every reader updated in the same change: build_binary.mjs, build_app_bundle.mjs, refresh_manifest.mjs, both repo-sync.sh copies, rebuild_amicode_check.sh. The .source sidecar ↔ rebuild_amicode_check coupling (overlay <sha>) is preserved.

B. fetch_opencode.mjs fork-branch excision. Removed isFork/private, the AMICODE_RELEASE_TAG/AMICODE_RELEASE_REPO override, the gh private-download fallback, assertReleaseChannel, ghApi, shaFromSums, and the if(coords.isFork) branch. The script stays the stock-canonical (anomalyco/opencode@v<version>) dev-bootstrap; release.yml uses build_binary.mjs and never this script (asserted by release_workflow.test.ts). Override/channel tests removed (not skipped).

C. Stale-comment fixes. assert_ui_gate.sh line 90's present-tense fork claim → the overlay-built engine's stock middleware (HISTORY: block preserved); dependency_resolver.ts dropped the orphaned "fork clone (local mode only)" comment (retired in S10).

Closure criterion

No live code path fetches/clones/resolves harmoniqs/opencode (already true post-#1137/#1138). Retained by design: accurate history comments (known_fixes.mjs, run_dir_reader.ts mirror pointer), report-a-bug engine routing, and the closure guard's own grep.

Gates

  • fetch_opencode + download_robustness tests: 20/20
  • rebuild_amicode_check.sh harness: 12/12 (incl. AC1 fork-refs == 0)
  • bash -n + shellcheck: clean on all 4 touched scripts
  • fast suite: 3579 pass; 2 failures are pre-existing environmental (fresh worktree has no vendored binary; a clipboard-tool 5s timeout) — proven identical on clean origin/main with my changes stashed. Zero regressions from this PR.

Draft until CI confirms green.

Source

Part of #1091 · post-alpha follow-up. Durable record: docs/adr/0019-overlay-provenance-naming.md.

Refs #1118 #1091

The final closure of #1091's 'no source references harmoniqs/opencode'
criterion, now that v0.3.6-alpha.1 validated the overlay-build binary
end-to-end (release.yml run 34855247762).

Three independent clusters:

A. Manifest provenance rename (atomic). packages/app-bundle/manifest.json:
   fork_ref/fork_tag/fork_sha -> overlay_ref/overlay_tag/overlay_sha,
   scope reworded fork-agnostic, schema 5->6. All readers updated in the
   same change: build_binary.mjs, build_app_bundle.mjs, refresh_manifest.mjs,
   both repo-sync.sh copies, rebuild_amicode_check.sh. The .source sidecar
   <-> rebuild_amicode_check coupling ('overlay <sha>') is preserved.

B. fetch_opencode.mjs fork-branch excision. Removed isFork/private, the
   AMICODE_RELEASE_TAG/AMICODE_RELEASE_REPO override, the gh private-download
   fallback, assertReleaseChannel, ghApi, shaFromSums, and the if(coords.isFork)
   branch. The script stays the stock-canonical (anomalyco/opencode@v<version>)
   dev-bootstrap; release.yml uses build_binary.mjs and never this script.
   Removed the override/channel tests (not skipped).

C. Stale-comment fixes. assert_ui_gate.sh line 90's present-tense fork claim
   -> the overlay-built engine's stock middleware (HISTORY: block preserved);
   dependency_resolver.ts dropped the orphaned 'fork clone (local mode only)'
   comment (that mode was retired in S10).

Closure criterion = no LIVE code path fetches/clones/resolves harmoniqs/opencode
(already true). Retained by design: accurate history comments (known_fixes,
run_dir_reader mirror pointer), report-a-bug engine routing, and the closure
guard's own grep.

Decision recorded in docs/adr/0019-overlay-provenance-naming.md.

Gates: fetch_opencode + download_robustness tests 20/20; rebuild_amicode_check
12/12 (incl. AC1 fork-refs==0); bash -n + shellcheck clean; fast suite has only
2 pre-existing env failures (no vendored binary / clipboard-tool timeout),
proven identical on clean origin/main.

Refs #1118 #1091
@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 44 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: ebdf999b-1a9c-4fec-80e2-82877551e5bf

📥 Commits

Reviewing files that changed from the base of the PR and between f3ab4a1 and d6647f5.

📒 Files selected for processing (12)
  • docs/adr/0019-overlay-provenance-naming.md
  • packages/app-bundle/manifest.json
  • packages/app-bundle/scripts/refresh_manifest.mjs
  • packages/extension/scripts/assert_ui_gate.sh
  • packages/extension/scripts/build_app_bundle.mjs
  • packages/extension/scripts/build_binary.mjs
  • packages/extension/scripts/fetch_opencode.mjs
  • packages/extension/scripts/repo-sync.sh
  • packages/extension/src/rebuild/dependency_resolver.ts
  • packages/extension/test/fetch_opencode.test.ts
  • scripts/rebuild_amicode_check.sh
  • scripts/repo-sync.sh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jeonghun-jj-lee
jeonghun-jj-lee marked this pull request as ready for review September 14, 2026 17:35
@jeonghun-jj-lee
jeonghun-jj-lee merged commit 0c36d87 into main Sep 14, 2026
11 checks passed
@jeonghun-jj-lee
jeonghun-jj-lee deleted the jj/1118-fork-vocabulary-sweep branch September 14, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sweep residual fork vocabulary from provisioning + naming (post-alpha, fork-absorption)

1 participant