chore(#1118): sweep residual fork vocabulary from provisioning + naming - #1141
Merged
Merged
Conversation
The final closure of #1091's 'no source references harmoniqs/opencode' criterion, now that v0.3.6-alpha.1 validated the overlay-build binary end-to-end (release.yml run 34855247762). Three independent clusters: A. Manifest provenance rename (atomic). packages/app-bundle/manifest.json: fork_ref/fork_tag/fork_sha -> overlay_ref/overlay_tag/overlay_sha, scope reworded fork-agnostic, schema 5->6. All readers updated in the same change: build_binary.mjs, build_app_bundle.mjs, refresh_manifest.mjs, both repo-sync.sh copies, rebuild_amicode_check.sh. The .source sidecar <-> rebuild_amicode_check coupling ('overlay <sha>') is preserved. B. fetch_opencode.mjs fork-branch excision. Removed isFork/private, the AMICODE_RELEASE_TAG/AMICODE_RELEASE_REPO override, the gh private-download fallback, assertReleaseChannel, ghApi, shaFromSums, and the if(coords.isFork) branch. The script stays the stock-canonical (anomalyco/opencode@v<version>) dev-bootstrap; release.yml uses build_binary.mjs and never this script. Removed the override/channel tests (not skipped). C. Stale-comment fixes. assert_ui_gate.sh line 90's present-tense fork claim -> the overlay-built engine's stock middleware (HISTORY: block preserved); dependency_resolver.ts dropped the orphaned 'fork clone (local mode only)' comment (that mode was retired in S10). Closure criterion = no LIVE code path fetches/clones/resolves harmoniqs/opencode (already true). Retained by design: accurate history comments (known_fixes, run_dir_reader mirror pointer), report-a-bug engine routing, and the closure guard's own grep. Decision recorded in docs/adr/0019-overlay-provenance-naming.md. Gates: fetch_opencode + download_robustness tests 20/20; rebuild_amicode_check 12/12 (incl. AC1 fork-refs==0); bash -n + shellcheck clean; fast suite has only 2 pre-existing env failures (no vendored binary / clipboard-tool timeout), proven identical on clean origin/main. Refs #1118 #1091
|
Warning Review limit reachedNext included review available in 44 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (12)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jeonghun-jj-lee
marked this pull request as ready for review
September 14, 2026 17:35
Closed
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1118. The final closure of #1091's "no source references
harmoniqs/opencode" criterion, now thatv0.3.6-alpha.1validated the overlay-build binary end-to-end (release.yml run 34855247762).Designed via grill-with-docs; decision recorded in
docs/adr/0019-overlay-provenance-naming.md. Design-of-record: issue #1118 body.Three independent clusters
A. Manifest provenance rename (atomic).
packages/app-bundle/manifest.json:fork_ref/fork_tag/fork_sha→overlay_ref/overlay_tag/overlay_sha,scopereworded fork-agnostic,schema5→6. Every reader updated in the same change:build_binary.mjs,build_app_bundle.mjs,refresh_manifest.mjs, bothrepo-sync.shcopies,rebuild_amicode_check.sh. The.sourcesidecar ↔rebuild_amicode_checkcoupling (overlay <sha>) is preserved.B.
fetch_opencode.mjsfork-branch excision. RemovedisFork/private, theAMICODE_RELEASE_TAG/AMICODE_RELEASE_REPOoverride, theghprivate-download fallback,assertReleaseChannel,ghApi,shaFromSums, and theif(coords.isFork)branch. The script stays the stock-canonical (anomalyco/opencode@v<version>) dev-bootstrap;release.ymlusesbuild_binary.mjsand never this script (asserted byrelease_workflow.test.ts). Override/channel tests removed (not skipped).C. Stale-comment fixes.
assert_ui_gate.shline 90's present-tense fork claim → the overlay-built engine's stock middleware (HISTORY:block preserved);dependency_resolver.tsdropped the orphaned "fork clone (local mode only)" comment (retired in S10).Closure criterion
No live code path fetches/clones/resolves
harmoniqs/opencode(already true post-#1137/#1138). Retained by design: accurate history comments (known_fixes.mjs,run_dir_reader.tsmirror pointer),report-a-bugengine routing, and the closure guard's own grep.Gates
fetch_opencode+download_robustnesstests: 20/20rebuild_amicode_check.shharness: 12/12 (incl. AC1 fork-refs == 0)bash -n+shellcheck: clean on all 4 touched scriptsfastsuite: 3579 pass; 2 failures are pre-existing environmental (fresh worktree has no vendored binary; a clipboard-tool 5s timeout) — proven identical on cleanorigin/mainwith my changes stashed. Zero regressions from this PR.Draft until CI confirms green.
Source
Part of #1091 · post-alpha follow-up. Durable record:
docs/adr/0019-overlay-provenance-naming.md.Refs #1118 #1091