The update_volume method should be removed ?

[SantiagoSotoC]

The update_volume method in the client class does not make sense, in my opinion it should be removed, there is the set_volume method that performs the function correctly.

In my opinion it just makes the use of the library confusing.

[luar123]

Yes it is confusing. Mostly because of missing documentation.
But there is a fundamental difference:
update_volume changes the internal state of the client object only. It is called by server.py when another control client changes the volume and therefore a notificatoon from the server is received. It should never be called by the user as it would lead to a disconnect between the server and the client object.
set_volume sends the request to the server and changes the internal state. So this should.be called by the user.

Same for other update_ and set_ methods.

[SantiagoSotoC]

I had not seen it in the server class, I searched with the ide and did not find anything.

So it should be indicated in the docstring ?

[luar123]

python-snapcast/snapcast/control/server.py

Line 397 in aa14561

self._clients.get(data.get('id')).update_volume(data)