Skip to content

fix(release): pin Ghostty source revision - #78

Merged
roodboi merged 3 commits into
mainfrom
codex/pin-ghostty-release
Sep 2, 2026
Merged

fix(release): pin Ghostty source revision#78
roodboi merged 3 commits into
mainfrom
codex/pin-ghostty-release

Conversation

@roodboi

@roodboi roodboi commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • pin the macOS Ghostty VT source to the last revision proven by a successful signed release build
  • make local setup and the release workflow consume one immutable revision file
  • add a regression test that rejects unpinned Ghostty source behavior and document the pin

Verification

  • bun test tests/macos-ghostty-source.test.ts
  • bun run check
  • git diff --check
  • verified a shallow fetch and detached checkout resolves exactly 53bd14fecfd68c6c0ab64d37b5943247299e2b40

Release decision

This is a fix and should trigger a patch release. The v4.0.0 CLI and Homebrew artifacts published successfully, but its macOS app job failed after an unpinned Ghostty HEAD drifted beyond the pinned Zig toolchain. The patch release must be followed through the signed macOS build and publication.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-02T14:57:12.822488Z 4ace6be Manual request
🔒 Security Review Completed 2026-09-02T14:58:10.836293Z 4ace6be Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ea125d548e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/macos-ghostty-source.test.ts

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3c9c3d36a6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/macos-ghostty-bundle.ts
@roodboi

roodboi commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@codex security review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 4ace6be219

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 4ace6be219

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@roodboi
roodboi merged commit 67976a0 into main Sep 2, 2026
6 checks passed
@roodboi
roodboi deleted the codex/pin-ghostty-release branch September 2, 2026 14:59
roodboi pushed a commit that referenced this pull request Sep 2, 2026
## [4.0.1](v4.0.0...v4.0.1) (2026-09-02)

### Bug Fixes

* **release:** pin Ghostty source revision ([#78](#78)) ([67976a0](67976a0))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant