fix(release): recognize bang breaking markers - #76
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
roodboi
added a commit
that referenced
this pull request
Sep 2, 2026
## Summary - pin `conventional-changelog-conventionalcommits` 8.0.0, compatible with semantic-release 25 and changelog-writer 8.2 - extend the release regression through both major-version analysis and rendered breaking-change notes ## Why Release Prepare correctly selected v4.0.0 after PR #76, but preset 10 requires changelog-writer 9+ and failed during note generation. Preset 8 provides the current config API without exceeding the writer version bundled by semantic-release 25. ## Verification - `bun test tests/release-config.test.ts` - `bun run check` - `bunx tsc -p packages/cli/tsconfig.json --noEmit` - `git diff --check` ## Release decision Yes. This release-pipeline correction should carry a patch signal. The unreleased breaking commit from PR #75 remains in the semantic-release range, so the next successful run should publish v4.0.0. <!-- codesmith:footer --> --- <a href="https://app.blacksmith.sh/hack-dance/codesmith/hack/pr/77"><picture><source media="(prefers-color-scheme: dark)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v2.svg"><source media="(prefers-color-scheme: light)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-light-v2.svg"><img alt="View with [code]smith" src="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v2.svg"></picture></a> <a href="https://backend.blacksmith.sh/track/enable-autofix?expires=1790950695&installation_model_id=17053&pr_number=77&repository=hack-dance%2Fhack&return_to=https%3A%2F%2Fgithub.com%2Fhack-dance%2Fhack%2Fpull%2F77&signature=fef90926c64f91c3afa81b421781288e8c13fdd9725aefd62c50883b7198812e"><picture><source media="(prefers-color-scheme: dark)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-light.svg"><img alt="Autofix with [code]smith" src="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"></picture></a> <sup>Need help on this PR? Tag <code>@codesmith-bot</code> with what you need. Autofix is disabled.</sup> <!-- codesmith:autofix:disabled --> <!-- /codesmith:footer -->
roodboi
pushed a commit
that referenced
this pull request
Sep 2, 2026
![https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v2.svg"><source](https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v2.svg"><source){kind=link}
![https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-light-v2.svg"><img](https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-light-v2.svg"><img){kind=link}
![https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v2.svg"></picture></a](https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v2.svg"></picture></a){kind=link}
![https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"><source](https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"><source){kind=link}
![https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-light.svg"><img](https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-light.svg"><img){kind=link}
![https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"></picture></a](https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"></picture></a){kind=link}
## [4.0.0](v3.5.2...v4.0.0) (2026-09-02) ### ⚠ BREAKING CHANGES * remove implicit agent writes and retired surfaces ### Features * remove implicit agent writes and retired surfaces ([bb10f99](bb10f99)) ### Bug Fixes * **release:** recognize bang breaking markers ([8db8742](8db8742)), closes [#75](#75) [#75](#75) * **release:** use compatible changelog preset ([f211223](f211223)), closes [#76](#76) [#75](#75)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feat!:as a major releaseWhy
Release Prepare passed after PR #75 merged but emitted “no release” because the transitive preset exposed the legacy configuration shape. The unreleased breaking commit remains on
main; once this fix lands, semantic-release will analyze both commits and publish the intended v4 release.Verification
bun test tests/release-config.test.tsbunx tsc -p packages/cli/tsconfig.json --noEmitbun run checkbun x ultracite checkgit diff --checkRelease decision
Yes. This is a release-pipeline fix and should carry a patch signal; combined with the still-unreleased
feat!:commit from PR #75, the next Release Prepare run must produce the intended major release.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.