Update SCTE-35 HLS reference hashes for presentationTimeOffset fix - #77
Open
JungleGenius wants to merge 1 commit into
Open
Update SCTE-35 HLS reference hashes for presentationTimeOffset fix#77JungleGenius wants to merge 1 commit into
JungleGenius wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion testsuite update for gpac/gpac#3891.
The GPAC source change correctly applies the presentation time offset when serializing SCTE-35 timing into HLS.
Using the existing
scte35-simple.tsfixture, the source stream has an 80 ms presentation-time offset. The GPAC change therefore adjusts the SCTE event presentation times from 2.000 / 4.000 seconds to 1.920 / 3.920 seconds.This changes the expected output of:
scte35-dasher-hls-simplescte35-dasher-hls-multiThe corresponding reference hashes have been regenerated using GPAC built directly from:
fix/02-hls-scte35-presentation-time-offsetOnly the two SCTE-35 HLS reference hash files are updated.