feat(math): complete SIMD distance kernels - #96
Merged
Merged
Conversation
Deploying xvec with
|
| Latest commit: |
10ca6ed
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://62ead15d.xvec.pages.dev |
| Branch Preview URL: | https://feat-complete-math-simd.xvec.pages.dev |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
==========================================
- Coverage 81.41% 81.23% -0.18%
==========================================
Files 150 149 -1
Lines 30672 30743 +71
==========================================
+ Hits 24971 24974 +3
- Misses 5699 5767 +68
Partials 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
math_batchFP16 scalar APIs and tests intodistance.goanddistance_test.goVbut not the optionalZvfhminextension required for safe dispatchVerification
go test -p 1 ./...go test -p 1 -tags noasm ./...go vet ./...make test-neonininternal/ailego/math_batchmake test-lasxininternal/ailego/mathandinternal/ailego/math_batchmake test-rvvininternal/ailego/mathandinternal/ailego/math_batchNotes
The architecture-specific tests skip when the required CPU features are unavailable. FP16 NEON dispatch requires both
HasFPHPandHasASIMDHP.