Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
==========================================
- Coverage 81.68% 81.39% -0.29%
==========================================
Files 148 148
Lines 30253 30253
==========================================
- Hits 24712 24625 -87
- Misses 5539 5626 +87
Partials 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloudflare Workers Builds completes
pnpm build, butnpx wrangler deployfinds no Wrangler configuration and starts automatic Astro adapter setup. That setup fails on the missingpublic/.assetsignorepath.Add
docs/wrangler.jsoncfor Workerxvec, serving the already-generated./distdirectory as Workers Static Assets. Pin Wrangler 4.140.0 in the pnpm dependencies and lockfile so the existing deploy command uses the installed version. Allow workerd's binary installation for local validation, ignore.wrangler, and document the Workers Builds settings. SVGs and other generated files remain only in ignored build directories.Validation:
pnpm install --frozen-lockfileandpnpm buildpass.wrangler deploy --dry-runreads all 8 built assets without invoking automatic project setup.No live deployment was performed. Cloudflare can retain root directory
docs, build commandpnpm build, and deploy commandnpx wrangler deploy.