Repository navigation
Allow per-call object detection snapshots and backends - #580
Merged
Merged
Conversation
Queue explicit snapshot/backend requests without changing the shared detector configuration. Keep supplied frames aligned with their camera and depth snapshots, and update the objects3d callers to use the new inputs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
the 3D detector has to patch the shared camera getter and switch the global backend to reuse a captured frame. overlapping calls can also pick up an in-flight result for the wrong request. this is the
runDetection({snapshot, backend})follow-up from #417.adds per-call inputs and queues explicit requests separately, keeping their camera/depth state while they wait. calls without inputs still share the active detection, and simulator ground truth keeps taking precedence. switches the addon and demo callers over; the larger demo migration stays in #487.
tested in the desktop simulator with real MediaPipe, and manually in the browser with live Gemini. also ran 41 browser cases for queueing, errors and cleanup (Gemini responses mocked in those automated cases). full SlimSAM validation and headset testing remain outstanding.
Type of Change
Media / Screen Recordings & Screenshots (If Applicable)
Checklist