feat(detect_targets): enable HWY_WASM by default on WebAssembly (fixes #2831) - #3369
Open
jdymitarai wants to merge 3 commits into
Open
jdymitarai wants to merge 3 commits into
jdymitarai wants to merge 3 commits into
Conversation
Member
|
Unfortunately this is nontrivial to land, we have some internal projects which turn out to break when enabling SIMD by default, which is why #2851 was rolled back. How much of an issue is it for you that -msimd128 is required to be passed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As reported in #2831,
hwy::DispatchedTargetpreviously returnedHWY_EMU128on WebAssembly unless the-msimd128compiler flag was passed explicitly, becauseHWY_BASELINE_WASMcheckeddefined(__wasm_simd128__).Solution
Enable
HWY_WASMby default onHWY_ARCH_WASMwithout requiring-msimd128, as discussed in #2831. WASM SIMD (simd128) is now widespread across modern web browsers and runtimes.Developers building a non-SIMD fallback WebAssembly binary can cleanly opt out by specifying
HWY_DISABLED_TARGETS=HWY_WASM(orHWY_COMPILE_ONLY_SCALAR), which falls back toHWY_EMU128/HWY_SCALAR.Fixes #2831.