Repository navigation
Fix for hot reload crash - #2060
Merged
Merged
Conversation
Ivorforce
approved these changes
Oct 7, 2026
Member
|
This also needs a squash before it can be merged. See https://contributing.godotengine.org/en/latest/development/workflows/creating_pull_requests.html#the-interactive-rebase |
Ivorforce
added
bug
Broke up memnew_placement macro to avoid creating a Ref<T> that will immediately be destroyed.
Contributor
Author
Made your suggested change and squashed the commits. Thanks for the docs on how to do that. |
dsnopek
approved these changes
Oct 9, 2026
dsnopek
left a comment
dsnopek
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! This looks good to me too :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Broke up memnew_placement macro to avoid creating a Ref that will immediately be destroyed.
Fix for #2059