You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
apologies, just came across your repo via your CN thread
scanning the code looking for what solver you were using,
my eye got snagged on the inconsistent letter case in the word "POSt"
on the given line.
It may be case insensitive ( I do see the use of "post" elsewhere)
Just advocating for consistency,
if it were me, I would have done it by mistake and want to fix it.
Thank you for pointing that out. That is in experimental code and probably has never been called. I would have wondered why it did not work or perhaps did but got distracted. That feature (measure transparency) is experimental and I have decided it can not be relied upon. At the time I wrote it I was not so experienced with github and now would have created a development branch for it.
Dale
On 01/07/2023 3:54 PM Tom Conlin ***@***.***> wrote:
apologies, just came across your repo via your CN thread
scanning the code looking for what solver you were using,
my eye got snagged on the inconsistent letter case in the word "POSt"
on the given line.
It may be case insensitive ( I do see the use of "post" elsewhere)
Just advocating for consistency,
if it were me, I would have done it by mistake and want to fix it.
Great job by the way. well done.
—
Reply to this email directly, view it on GitHub #1 (comment) , or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2BJLBV3BHDBEHOHWLZTQDWRHQYBANCNFSM6AAAAAATUEE6EE .
You are receiving this because you commented.Message ID: ***@***.***>
https://github.com/githubdoe/skysolve/blob/main/skysolve.py#L808