Improve CERT DCL30-C stack return analysis - #1188
Open
JeewoongKim wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #495.
This updates the CERT C
DCL30-Cfunction-return query to use the stack-return analysisfrom
cpp/return-stack-allocated-memory.The previous implementation used the legacy local data-flow API and missed some stack-derived
pointer returns. (e.g.,
char a[2] ; return a + 1;)The changes include:
MustFlowanalysisThe function-return query now focuses on return values. Stack-address escapes through output
parameters are still covered by the separate
AppropriateStorageDurationsStackAdressEscapequery.Tested locally:
codeql test run --show-extractor-output c/cert/test/rules/DCL30-Cpython scripts/validate-rule-package.py c/Declarations8Change request type
.ql,.qll,.qlsor unit tests)Rules with added or modified queries
Release change checklist
Author: Is a change note required?
Query development review checklist
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.