fix(helm): recreate the rustfs bucket-init Job, its image from gsoci - #85
Merged
Merged
Conversation
Member
Author
|
From Timo's agent: lab proof on a local kind lab running agent-platform 4.79.0 (Substrate 1.1.1 through the meta chart's Flux
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
rustfs-bucket-initJob is a plain release resource, and a Job's pod template is immutable. Any change of its image fails the upgrade of every installation withspec.template: … field is immutableuntil someone deletes the completed Job by hand. So the chart kept Docker Hub's short nameamazon/aws-cli, the one image the platform can't pull from gsoci yet (giantswarm/agent-platform#580).Change
post-install,post-upgrade, delete policybefore-hook-creation,hook-succeeded. It's recreated on every install and upgrade under the same name, which network policies select the pod by (job-name). On an upgrade from a release where the Job is a release resource, Helm deletes the old Job (it's gone from the manifest) and the post-upgrade hook creates the new one. A completed Job is deleted: left behind, it would block a rollback to such a release with an unowned object of the same name.hack/install-microvm-deps.shandhack/microvm-assets/stage-to-rustfs.shwait for the Job only while it exists: a Helm install ran it to completion, and a Kustomize install leaves it to be waited for.stage-to-rustfs.shruns the same gsoci image.images.awsCliis the gsoci copygsoci.azurecr.io/giantswarm/aws-cli:2.17.0, same digest as upstream's pin.tests/rustfs_test.yamlholds the hook;tests/images_test.yamlholds the gsoci default. FORK.md gets a carried-patch row;manifests/ate-install/rustfs.yamlis re-rendered.Checks
helm unittest charts/substrate: 53/53 pass.Proof
An agentlab upgrade from 1.1.1 to this branch's dev build: the old Job goes, the hook Job runs from gsoci and completes, and the Substrate HelmRelease is Ready. Result to follow in a comment.