fix(aiohttp): Gate server request query_string via data_collection option - #7300
Open
ericapisani wants to merge 1 commit into
Open
fix(aiohttp): Gate server request query_string via data_collection option#7300ericapisani wants to merge 1 commit into
ericapisani wants to merge 1 commit into
Conversation
…tion Filter the request event's query_string through the url_query_params data_collection behaviour, mirroring the existing gating for the client span's url.query attribute. Fixes PY-2752 Fixes #7299
Contributor
Codecov Results 📊✅ 119159 passed | ⏭️ 6762 skipped | Total: 125921 | Pass Rate: 94.63% | Execution Time: 422m 48s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2494 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 90.29% 90.26% -0.03%
==========================================
Files 193 193 —
Lines 25601 25606 +5
Branches 9436 9442 +6
==========================================
+ Hits 23116 23112 -4
- Misses 2485 2494 +9
- Partials 1435 1437 +2Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filter the request event's query_string through the url_query_params data_collection behaviour, mirroring the existing gating for the client span's url.query attribute.
Fixes PY-2752
Fixes #7299