ref(aiohttp): Remove dead segment name code - #7284
Open
mjq wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 985bfad. Configure here.
Contributor
Codecov Results 📊✅ 119060 passed | ⏭️ 6762 skipped | Total: 125822 | Pass Rate: 94.63% | Execution Time: 442m 34s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2483 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 90.29% 90.30% +0.01%
==========================================
Files 193 193 —
Lines 25601 25596 -5
Branches 9436 9434 -2
==========================================
+ Hits 23116 23113 -3
- Misses 2485 2483 -2
- Partials 1435 1434 -1Generated by Codecov Action |
mjq
marked this pull request as ready for review
August 28, 2026 14:21
mjq
marked this pull request as draft
August 28, 2026 14:25
mjq
force-pushed
the
mjq/aiohttp-streamedspan-branch
branch
from
August 28, 2026 14:34
985bfad to
ad70524
Compare
mjq
force-pushed
the
mjq/aiohttp-streamedspan-branch
branch
from
August 28, 2026 14:39
5ee183d to
566edcf
Compare
mjq
marked this pull request as ready for review
August 28, 2026 14:40
mjq
force-pushed
the
mjq/aiohttp-streamedspan-branch
branch
from
August 28, 2026 14:48
566edcf to
c41605f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
aiohttpintegration currently has a dead branch that looks live:sentry-python/sentry_sdk/integrations/aiohttp.py
Lines 341 to 356 in 8e6d73b
isinstance(current_span, StreamedSpan)is always false, so the first branch never matches.sentry_sdk.get_current_span()does not returnStreamedSpans. (It reads fromscope.span, but the streamed span is inscope.streamed_span).This doesn't functionally matter, because even though we always fall through to the
elsebranch,set_transaction_namealready handles the streamed span case (including the name and source). This is tested intest_transaction_style_span_streamingalready.Remove the misleading branch.