fix: describe service interface generation as a boolean flag - #84
Merged
Merged
Conversation
Greenhouse decisions/0353 and evidence/0670: the published string schema implied an existing contract, while the generator creates a local companion. Native CLI/MCP cattle pass 9/9 with the corrected schema (baseline 4/9).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
makeoperation advertisedinterfaceas a string naming the interface a service implements, but the generator treats it as a flag that creates a local<Name>Interface. MCP consequently rejected JSON booleans and accepted a misleading FQCN string.Declare the optional input as boolean and explain the companion semantics in its description and README. Existing generation code is unchanged: omit/false produces a plain class; true creates its companion. Implement an existing SDK contract when implementing the class.
Validation: a red→green schema regression; 434 tests / 1,935 assertions, 92.43% coverage; PHPStan, style, Composer, docblocks and attribution pass. Fresh greenhouse cattle exercise actual CLI and native MCP projection/dispatch: baseline 4/9, candidate 9/9, 46 protected files and five rejecting auditor mutants per run. MCP evidence comes from its isolated trial copy, with host preservation verified.
Governed by greenhouse decisions/0353 and evidence/0670. A fresh Packagist replay is required after release; no claim of completed resident UI authorship.