Repository navigation
Add configurable naming/grouping for OBJ export - #24
Merged
Merged
Conversation
export_obj/export_mesh gain object_namer/group_namer/group_by
callbacks controlling the `o`/`g` lines, so callers can name exports
after e.g. the source object's Citation title instead of its URI, and
merge several representations into one OBJ file with distinguishable
`o` blocks (grouped by source object or by RESQML/EML qualified type).
All new parameters default to None and reproduce the exact previous
mapping when unused (FormatSpec.supports_naming gates them so other
formats are unaffected). Keys off patch.energyml_object rather than
patch.identifier/source_uuid, since the legacy AbstractMesh has
neither field and suffixes identifier with "_patch{n}", which would
otherwise split a multi-patch representation into one group per patch.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
export_obj/export_mesh gain object_namer/group_namer/group_by callbacks controlling the
o/glines, so callers can name exports after e.g. the source object's Citation title instead of its URI, and merge several representations into one OBJ file with distinguishableoblocks (grouped by source object or by RESQML/EML qualified type).All new parameters default to None and reproduce the exact previous mapping when unused (FormatSpec.supports_naming gates them so other formats are unaffected). Keys off patch.energyml_object rather than patch.identifier/source_uuid, since the legacy AbstractMesh has neither field and suffixes identifier with "_patch{n}", which would otherwise split a multi-patch representation into one group per patch.