feat(cli): add SDK-backed Gemini Markets CLI - #50
Conversation
Nostradamus Risk Rating — MediumThe PR adds a new OAuth PKCE credential lifecycle (login, storage, refresh) for a CLI that can place orders on the Gemini exchange, with |
ximt
left a comment
There was a problem hiding this comment.
Requested changes. I found seven actionable correctness and safety issues, described inline: the stream lifecycle subscriber can be closed on overflow and is silently discarded; credentials are keyed only by profile rather than environment; prediction-order validation hard-codes a price grid and accepts decimal syntax the API validator rejects; history-only flags can be silently ignored; time-bounded history accepts an offset the API ignores; and the README claims the current SDK tags are signed when they are only annotated. CLI and SDK go test ./..., go test -race ./..., go vet ./..., formatting, module verification, and CLI help/build checks pass, but those checks do not cover these contract mismatches.
Change Control Evidence CheckAuthorization — ❌ FailEvidence:
Testing — ✅ PassEvidence:
Approval — ✅ PassEvidence:
Segregation of Duties — ✅ PassValidated:
Last checked: 2026-09-09 00:13 UTC ↩ Re-run Clarissa if tickets, CI, or approvals have changed. |
ximt
left a comment
There was a problem hiding this comment.
Re-reviewed the latest head 269a940. The author addressed all previously reported correctness and safety issues, and I found no new critical or important code findings. CLI, SDK, generator, race, vet, formatting, module verification, and published-spec checks pass. Approved from a code-review perspective. The separate ssdlc/validation check is still failing because its evidence report has no linked ticket/authorization metadata.
Summary
Validation
make check: module verification, tests, race tests, vet, build, package docs, and help smoke test.git diff --check.The CLI remains pre-release; release automation and published binaries are intentionally left for follow-up work.