Skip to content

Declare NodeRequire and put certify refusals in --report so corpus can name them - #1

Open
merveuygunerdol wants to merge 1 commit into
mainfrom
fix/noderequire-and-report-refusals
Open

merveuygunerdol wants to merge 1 commit into
mainfrom
fix/noderequire-and-report-refusals

Conversation

@merveuygunerdol

@merveuygunerdol merveuygunerdol commented Sep 23, 2026 •

Copy link
Copy Markdown

…n name them100

Summary by CodeRabbit

  • New Features
    • Node.js type declarations now recognize NodeRequire, __filename, and __dirname.
    • Build reports can display certification-stage refusals and slot-drift details, including available reasons.

@github-actions

Copy link
Copy Markdown

Thanks for the pull request. Before it can be merged, please read the GeaStack Contributor License Agreement and sign it by posting a comment here with exactly:


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: d1a87c01-e769-48cf-a41a-737a59cfda4a

📥 Commits

Reviewing files that changed from the base of the PR and between 8cdbc58 and 69c7dfa.

📒 Files selected for processing (3)
  • runtime/node/commonjs-wrapper.d.ts
  • runtime/node/node-globals.ts
  • scripts/build.mjs

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The changes add global Node type declarations and extend build report output with certification refusals and slot-drift details.

Changes

Node compatibility declarations

Layer / File(s) Summary
Global Node type declarations
runtime/node/commonjs-wrapper.d.ts, runtime/node/node-globals.ts
The declarations add NodeRequire. The wrapper also declares global __filename and __dirname as strings. No runtime require binding is added.

Build report details

Layer / File(s) Summary
Certification and slot-drift reporting
scripts/build.mjs
The build report includes up to 20 certification refusals and up to 10 slot-drift entries. Slot-drift entries use the reason when available, or source -> slot otherwise.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: dashersw

Merge Risk: ⚪ Minimal · up to 69c7d

No actionable merge-blocking risk is established; merge after normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes both main changes: declaring NodeRequire and adding certify refusals to --report.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@merveuygunerdol merveuygunerdol changed the title Declare NodeRequire and put certify refusals in --report so corpus ca… Declare NodeRequire and put certify refusals in --report so corpus can name them Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant