Add HTCondor support to availableCores() - #145
Open
LeonidasZhak wants to merge 1 commit into
Open
LeonidasZhak wants to merge 1 commit into
LeonidasZhak wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an
HTCondormethod toavailableCores()and include it in the default lookup sequence.Thanks to maintainers
Thanks for keeping this request open and for documenting the scheduler behavior expected by
availableCores().Issue or motivation
Fixes #50. HTCondor exposes the provisioned CPU count to jobs, but
parallellydid not query it.Root cause
The scheduler dispatch covered LSF, PBS, PJM, SGE, and Slurm, with no HTCondor lookup method.
Change
The new method reads
CpusProvisionedfrom_CONDOR_JOB_AD, thenCpusfrom_CONDOR_MACHINE_AD. If neither ClassAd value is available, it usesOMP_NUM_THREADSwhenBATCH_SYSTEMidentifies HTCondor. Documentation and NEWS are updated.Tests
parallelly:::testme("availableCores")R CMD check --as-cran --no-manual— Status: OKThe regression test covers job-ad precedence, machine-ad fallback, the HTCondor environment fallback, and rejection of an unrelated
OMP_NUM_THREADS.Scope
This only adds CPU-count detection to
availableCores(). It does not add HTCondor host discovery toavailableWorkers()or change existing scheduler methods.