Repository navigation
Sync upstream components and restore orange product branding - #285
Merged
Merged
Conversation
✅ Deploy Preview for fulldev-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
silveltman
changed the title
silveltman
added
the
review-ready
silveltman
marked this pull request as ready for review
October 17, 2026 07:21
Collaborator
Author
|
@coderabbitai review Review the current revision cafa692 for functional regressions, accessibility, registry portability and compatibility. This content-site upstream sync preserves intentional Astro adaptations and the documented Embla carousel API. Generated public/r files are required registry output; source, dependency inputs and affected callers are the primary review scope. The CLI source review assumed Collapsible 1.0.2, but package.json, pnpm-lock.yaml and all registry ranges now use published 1.1.2. Both dismissal attributes are supported by that release and pass Chromium, Firefox and WebKit interaction tests. Independent review found two small issues, both fixed in the current head: the orange preset swatch and absent/object/string style prop handling in CodeBlockContent. Required Check and the current Netlify preview pass. |
|
Collaborator
Author
|
@coderabbitai review Retry after the file-count rejection. The current branch adds only a repository path filter for generated public/r output, using configuration inheritance so existing review settings remain in force. All authored source, docs, registry definitions, dependency inputs and tests remain eligible. Required registry:check regenerates public/r and fails on differences, and the independent review also reproduced the generated output with zero difference. Review the content component changes and the two already-fixed independent findings described in the PR. @data-slot resolves to published 1.1.2, including Collapsible dismissal support. No paid continuation is requested. |
✅ Action performedReview finished.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Docstring Coverage |  |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 4… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Title check | |
The title clearly summarizes the pull request's two main changes: upstream component synchronization and restoration of orange product branding. |
| Description check | |
The description is directly related to the changeset and provides detailed context about the new components, dependency updates, branding changes, validation, and intentional compatibility decisions. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 4 files. (43 skipped: 43 unsupported.)
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring the content website components up to the current official shadcn/ui and data-slot sources while preserving Fulldev's Astro APIs, portable registry and eight styles. Give the docs site an orange product identity.
There are 51 source/docs/metadata/config files and 270 generated registry files. Generated output is required for installs and the site's update history.
Changes
Use Orange as the docs default theme and keep the logo tile orange across presets. Match the favicon, logo assets and social image. Separate the tile and UI wordmark with a decorative slash and 12px spacing, and record the product branding in
DESIGN.md.Add Astro Code Block: escaped text, optional line numbers and diff/highlighted lines, wrapping, keyboard scrolling, translated copy feedback and clipboard failure handling.
Add Astro Progress with native accessible semantics, labels, custom maxima, indeterminate state, RTL and reduced-motion support.
Update all installed
@data-slot/*ranges from 1.0.2 to the published 1.1.2 release. Expose Collapsible's opt-in Escape/outside-click dismissal, including focus return.Fix Combobox clear-button visibility after clearing and add a translatable accessible label.
Refresh the eight unmodified official style snapshots, update the React preview's Base UI dependency to 1.9.0, and regenerate registry output. Include docs, installable examples and a minor changeset.
Audit and intentional differences
Compared the existing Astro families and standard React preview fixtures with current official Base UI Vega CLI output and documentation, plus the data-slot 1.0.2 to 1.1.2 source changes. Existing React fixture structure, variants and defaults already match, so no wholesale replacements were needed.
The meaningful missing content components were Code Block and Progress. Collapsible dismissal and the Combobox clear behavior were the existing-component gaps. The remaining data-slot source change is Resizable's internal cursor optimization, picked up by the dependency update.
dirfor Astro. Official Scroll Area requires a custom scrollbar runtime, and Direction is a React context provider. React consumers can install the official parts directly.Live release metadata was checked. The audit CLI resolved to released 4.21.5 under the existing release-age policy and fetched the live registry; 4.22.0 was too recent for that policy.
@shadcn/lintis still published at 0.2.1, so no unreleased lint changes or release-age bypasses were used.Validation
Upstream synchronization at
0fa7c4307:vp run check: formatting, Astro/React types, lint, knip, image checks, registry validation/regeneration and 27 unit tests pass.vp run build: Astro docs, all eight React galleries, HTML validation and link crawl pass.vp run test:browser: all 35 tests pass. Affected Code Block, Progress, Collapsible and Combobox flows run in Chromium, Firefox and WebKit; existing React preview theme/mobile-header regressions also pass.Orange branding at
b1e2ee56d: focused Prettier/ESLint and image checks, nine registry tests and the full build pass. T3 review covers light/dark mode, mobile width, the orange primary color and switching presets while the logo keeps its product color.Deploy Preview. Branding deployment
b1e2ee56d494ad00d19c3ffc44d9a8dc1e6499a0is green; the deployed Orange default and orange logo were verified in T3. The upstream component deployment was checked for Code Block rendering and real clipboard copy, Progress semantics/geometry and Combobox clear/focus behavior.Start with Code Block, Progress and Collapsible dismissal.
Dispatch validation at
6b02d1eb0: focused formatting/lint, full build, all 18 affected Chromium/Firefox/WebKit component checks and both React-preview checks pass. T3 review of the deployed preview covers the new header in light/dark mode, 320px mobile width, menu navigation, Code Block clipboard success and Progress semantics. The header retains the accessible home-link name, hides the decorative slash from assistive technology and fits without horizontal overflow. Independent review is complete; required CI and the selected CodeRabbit PR review run at Ready.CodeRabbit CLI reviewed all 33 changed source files at
6b02d1eb0(generated output exceeded its 300-file limit). Its two duplicate findings assume Collapsible 1.0.2 and are rejected:package.json,pnpm-lock.yaml, registry dependency metadata and the installed package all use 1.1.2, whose runtime reads both dismissal attributes. The dismissal and focus regression tests pass in all three browser engines.Independent Opus review covered
b9113073d..6b02d1eb0, including actual rendered desktop/mobile components, and found no blockers. Both small findings are fixed atcafa692bf: use the orange brand token for the preset-menu swatch, and preserve absent/object/string Code Block style props. A focused rendered Astro fixture verifies all three style inputs, registry output was regenerated, and all 18 affected browser checks pass again. The preset menu's orange swatch and clean code style attribute were also verified in T3. The review's floating-copy-button spacing preference is left at official shadcn/ui parity. The fresh Astro build and all eight React gallery builds pass after reinstalling the frozen lockfile to repair broken local dependency links.CodeRabbit's PR file limit initially rejected generated output.
.coderabbit.yamlinherits existing settings and excludes only generatedpublic/r/**from AI review; authored registry inputs stay in scope and required CI continues to verify generated parity. No review requirement or paid usage setting was changed.Summary by CodeRabbit