Repository navigation
Keep the theme across ClientRouter navigation - #282
Merged
Merged
Conversation
Astro's ClientRouter copies the next page's <html> attributes, which cannot know the theme. ThemeProvider now carries the applied theme onto the next page in astro:before-swap, so the theme no longer flashes and the class observer no longer saves the server's light theme as the visitor's choice. Replaces #260, which predates the system preference syncing on main. Co-authored-by: El Mahdi Bennajah <bennajah.me@gmail.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for fulldev-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the active Astro theme being reset by ClientRouter navigation. The provider carries the latest theme into the incoming document immediately at the actual swap, preserving changes made during the fallback animation and the existing swap callback contract. System preference, storage synchronization and toggle behavior stay intact.
Replaces #260 with a minimal fix against current main. Includes regenerated registry output and a patch changeset.
Validation: focused ClientRouter regressions pass in Chromium, Firefox and WebKit. The fallback regression fails with the previous implementation. Independent review also verified manual, system and storage changes during the fade, callback compatibility, back navigation and system reset. Native iOS Safari and Android Chrome smoke checks pass. Current Netlify preview registry matches this head; preview theme controls and navigation work. Required CI runs at Ready.