Skip to content

Remove duplicate PR code checks and install-only release validation - #27

Merged
silveltman merged 2 commits into
mainfrom
perf/ci-runtime
Oct 6, 2026
Merged

silveltman merged 2 commits into
mainfrom
perf/ci-runtime

Conversation

@silveltman

@silveltman silveltman commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Ordinary pull requests ran pnpm check in both the required organization Check and local Validate. Run the local code check only on main pushes, retaining Changesets validation on ordinary PRs. Skip local Validate entirely for release PRs, where both useful steps are skipped; the required organization Check remains.

Validation: pnpm format/check/build and Changesets status passed. Effective main requirements and organization workflow were inspected; event truth table preserves the checks described above. Offline zizmor base/head findings are unchanged. Local general review and CodeRabbit CLI completed with no unresolved findings. Organization Check and local Changesets Validate passed on the current head; the duplicate Check code step is skipped. The Netlify Deploy Preview is ready and its commit matches. GitHub PR review has not run while draft.

Verified preview: https://6ac5314d4ccb810008000d3f--fulldev-sitex.netlify.app

Summary by CodeRabbit

  • Chores
    • Automated validation is skipped for pull requests from release-preparation branches.
    • Code checks now run on pushes rather than as part of the pull request workflow. These changes affect project checks and do not alter the product’s features or behavior for end users.

silveltman and others added 2 commits October 6, 2026 19:14
Pull requests already run pnpm check in the required organization Check, so
the local CI job ran it twice. Pull requests keep the local Changesets
check, and pushes to main keep pnpm check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Both Validate checks already skip changeset-release/ branches, so the job
only checked out and installed there. The organization Check still runs
on release pull requests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@silveltman
silveltman marked this pull request as ready for review October 6, 2026 19:13
@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 94f807f8-5895-48f8-8366-8c417d395749
📥 Commits

Reviewing files that changed from the base of the PR and between 9d89bae and 54fc5ed.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

Included review availability: This review used your included allowance. 2 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

The CI workflow skips the validate job for pull requests whose head branch starts with changeset-release/. The Check code step now runs only on pushes.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 54fc5

The change avoids duplicate pull-request code checks while retaining the described Changesets validation. No material CI gap is evident; merge after normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: removing duplicate pull request code checks and limiting release validation.
Description check ✅ Passed The description explains the CI changes, validation behavior, and reported checks. It is directly related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@silveltman
silveltman merged commit ce529d9 into main Oct 6, 2026
5 checks passed
@silveltman
silveltman deleted the perf/ci-runtime branch October 6, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant