Skip to content

Open release pull requests with a GitHub App token - #19

Merged
silveltman merged 1 commit into
mainfrom
chore/release-app-token
Sep 30, 2026
Merged

silveltman merged 1 commit into
mainfrom
chore/release-app-token

Conversation

@silveltman

@silveltman silveltman commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Pull requests opened with GITHUB_TOKEN do not start workflows, so the required organization Check waits for manual approval on the changesets release PR (see fulldotdev/scan#49).

The release workflow now creates a token for the fulldev-release GitHub App and uses it for checkout and changesets/action. Its client ID and private key come from the organization variable RELEASE_APP_CLIENT_ID and secret RELEASE_APP_PRIVATE_KEY, shared with scan, sitex and ui only.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated the release process to use dedicated credentials when checking out the repository and publishing changesets. This changes how releases are authorized; it does not add or remove any end-user features.

Pull requests opened with GITHUB_TOKEN do not start workflows, so the required organization Check waited for manual approval. The fulldev-release app token fixes that.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 4937119d-ef7b-4d92-a679-86a2e3d43fbb

📥 Commits

Reviewing files that changed from the base of the PR and between 0e0259f and eee0cf5.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The release workflow now creates a GitHub App token using RELEASE_APP_CLIENT_ID and RELEASE_APP_PRIVATE_KEY. Checkout and the Changesets action use this token instead of the default checkout token and repository GITHUB_TOKEN secret.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to eee0c

Release automation now uses the App token for checkout and Changesets. The reviewed workflow wiring presents no concrete merge blocker; normal release setup must provide the App credentials and permissions.

Architecture Summary

Architecture risk: 🔵 Low · up to eee0c

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/release.yml: Adds a step that creates a GitHub App token from the configured client ID and private key.
  • observed — Modified behavior in .github/workflows/release.yml: Checkout now uses the token created by the new step instead of its default token.
  • observed — Modified behavior in .github/workflows/release.yml: Changes the Changesets action’s GITHUB_TOKEN from the repository secret to the created GitHub App token.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: using a GitHub App token to open release pull requests.
Description check ✅ Passed The description explains the release workflow change and the reason for using a GitHub App token.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@silveltman
silveltman merged commit 99d3165 into main Sep 30, 2026
4 checks passed
@silveltman
silveltman deleted the chore/release-app-token branch September 30, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant