Skip to content
This repository was archived by the owner on Oct 14, 2026. It is now read-only.

Show the sign-in page in the Fulldev brand - #6

Merged
silveltman merged 1 commit into
mainfrom
design/brand-v2
Oct 7, 2026
Merged

silveltman merged 1 commit into
mainfrom
design/brand-v2

Conversation

@silveltman

@silveltman silveltman commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

The browser page after fulldev sign-in now uses the new full.dev brand (fulldev#69): stone background, the brand's text colour and font stack, and the blue logo tile from the site's favicon above the message.

A patch changeset is included, so the next release carries it.

Checks

  • pnpm check passes, including the committed dist.
  • The page rendered locally in Chrome; the CLI has no deploy preview.
  • CodeRabbit CLI: one finding (dist not updated), rejected: dist/cli.mjs is rebuilt in the same commit.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Style
    • Updated the OAuth sign-in callback page with Fulldev branding, refreshed styling, and an updated page title and viewport presentation. The callback message continues to appear on the page.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@silveltman
silveltman marked this pull request as ready for review October 7, 2026 07:55
@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 5b364576-6734-471c-b372-545265cd1989
📥 Commits

Reviewing files that changed from the base of the PR and between aa7b29c and f15d83b.

⛔ Files ignored due to path filters (1)
  • dist/cli.mjs is excluded by !**/dist/**
📒 Files selected for processing (2)
  • .changeset/brand-sign-in-page.md
  • src/oauth.ts

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

The OAuth callback page now displays a Fulldev-branded SVG tile and uses updated styling, title, and viewport metadata. The callback message remains on the page. A Changeset declares a patch release for fulldev.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to f15d8

The sign-in page’s presentation is updated without changing its callback message behavior. No actionable merge-blocking risk is apparent.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: applying Fulldev branding to the sign-in page.
Description check ✅ Passed The description explains the branding updates to the sign-in page and notes the changeset and reported checks.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 …
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@silveltman
silveltman merged commit 84519ee into main Oct 7, 2026
3 checks passed
@silveltman
silveltman deleted the design/brand-v2 branch October 7, 2026 15:28
@fulldev-release fulldev-release Bot mentioned this pull request Oct 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant