Repository navigation
Harden the organization check install - #5
Conversation
Always run the frozen install, cache the pnpm store instead of node_modules, skip pnpmfiles, protect nested installs, and pin actions to commit SHAs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Limit details: You’ve used all 10 included reviews currently available. 📝 WalkthroughWalkthroughThe check workflow pins the checkout and setup-node actions to commits. It sets pnpm options to ignore scripts and pnpmfiles. It replaces the Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to No actionable merge-blocking issue is established. The workflow’s behavior in consuming repositories should be observed after rollout. Architecture SummaryArchitecture risk: 🔵 Low · up to The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency. Changed systems: None identified. Architecture concerns Review detailsBefore / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Usage-based review receipt
Note This review exceeded your plan’s limits and used usage-based reviews—free during trial, billed after paid activation unless disabled. Manage usage-based reviews. Comment |
Hardens the install in the organization
Checkworkflow that the Merge policy ruleset requires on every pull request.Rebased on
mainafter #3 (checkout and setup-node 7) merged. Replaces #4, which GitHub closed when #3's branch was deleted.What changes
node_modulesand skippedpnpm install, so a run never checked the lockfile against the repository's pnpm settings or the registry. Now only the pnpm store (downloaded packages) is cached, keyed onpnpm-lock.yaml, andpnpm install --frozen-lockfileruns every time. That is wheretrustPolicy, the strict release age andignorePnpmfilefrom the per-repository PRs are enforced.--ignore-pnpmfileadded to the install, andpnpm_config_ignore_scripts/pnpm_config_ignore_pnpmfileset for the job, so installs started from acheckscript get the same protection. Explicitpnpm runscripts still run.actions/checkoutv7.0.1 andactions/setup-nodev7.0.0 (the currentv7tags, as Use checkout and setup-node 7 in the check workflow #3 set),actions/cachev6.1.0 (the currentv6tag).contents: readfor the check, write only on the CloudCannon auto-merge job, which is unchanged.Testing
actionlint1.7.12 and Prettier pass.pnpm store path --silentprints only the store path on pnpm 11.28.0 and 12.8.1.pnpm install --frozen-lockfile --ignore-scripts --ignore-pnpmfilewith pnpm 12.8.1, the version all 43 repositories now pin, passes on each repository's security PR rebased on currentmain.main, so other repositories only use it after merge. This PR's ownCheckfinds no package and exits with the "nothing to run" notice, so it does not exercise the new steps. Watch the first PRs after merging.Risks
node_modulescache hit, in exchange for a verified install.🤖 Generated with Claude Code
Summary by CodeRabbit