Failing with release 3.16.0

[aeschbacher]

The script fails with release 3.16.0, mainly because 7z fails to extract BluOS-Controller-3.16.0.dmg.

@andmarti1424 proposed another approach of using the Windows .exe instead of the macos .dmg and shared a way of extracting.

I followed this idea and could successfully build the AppImage for Linux. I do not have the time to provide a patch, but in this issue I'll explain how I got it running.

description

• download BluOS-Controller-Setup-3.16.0.exe
• extract whole archive (not only app.asar):

  archive=BluOS-Controller-Setup-3.16.0.exe
  7zr x "${archive}" -o"${tmp}"

• install node, yarn, electron-builder, npx:

  curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.0/install.sh | bash
  nvm install --lts
  nvm use --lts
  corepack enable
  yarn add electron-builder js-beautify npx --dev

• unpack asar

  npx asar extract "$tmp/resources/app.asar" "$tmp/app"
  cd "$tmp/app"

• patches
  • www/app.js

    npx js-beautify -r www/app.js
    # I applied usual patch manually to www/app.js

  • add analytics/fire-base.html as extra resources (application does not start without)

    mkdir resources
    cp -a ../resources/analytics resources/

  • Modify packages.json to add extra resource into AppImage

    diff -uN package-bak.json package.json
    --- package-bak.json	2021-12-11 15:08:44.213526221 +0100
    +++ package.json	2021-12-11 14:48:04.696173123 +0100
    @@ -24,5 +24,17 @@
         "electron": "^9.4.4",
         "electron-builder": "^22.14.5",
         "js-beautify": "^1.14.0"
    +  },
    +  "build": {
    +    "appId": "com.bluos.app",
    +    "extraResources": [
    +      {
    +        "from": "resources",
    +        "to": ".",
    +        "filter": [
    +          "**/*"
    +        ]
    +      }
    +    ]
      }
    }
    

• rebuild

  npx electron-builder -l AppImage

[frafra]

Thank you :)
Some patches are not applying, so I would need more time.
npx asar extract is also printing a strange error:

ENOENT: no such file or directory, open '/home/frafra/Code/bs-bashpatch/bluos-controller.Jey/app.asar.unpacked/node_modules/electron/LICENSE'

It would be nice to have a common repository with just the patches after running prettify, for each version.

[andmarti1424]

Yes indeed. Some patches fail and need to be updated. The error you mention might be because the app.asar.unpacked folder is not extracted?

[aeschbacher]

You need to extract the whole archive with
7zr x "${archive}" -o"${tmp}"

If you extract only app.asar (with 7z e) some files are missing (e.g. LICENSE, but then even other)

[aeschbacher]

We need probably a different patch for each version, e.g.

patches/3.14.1.patch
patches/3.16.0.patch

But as recent story taught us, perhaps even:

patches/dmg/3.14.1.patch
patches/exe/3.16.0.patch

[andmarti1424]

I managed to get it built following @aeschbacher instructions and adding:
"electronVersion": "16.0.4", in the build section of package.json
But nevertheless it builds ok, it does not work.
May be because of the patches that need to be applied.
I get these errors:

INS [mongo@arch ~/Downloads/bs-bashpatch/downloads/salida/dist][master]$ ./BluOS\ Controller-3.16.0.AppImage
[223083:1213/140058.884862:ERROR:gl_surface_egl.cc(734)] No suitable EGL configs found.
[223083:1213/140058.885065:ERROR:gl_context_egl.cc(286)] eglCreateContext failed with error EGL_BAD_CONFIG
[223083:1213/140058.902883:ERROR:gl_surface_egl.cc(734)] No suitable EGL configs found.
[223083:1213/140058.902973:ERROR:gl_surface_egl.cc(2172)] eglCreatePbufferSurface failed with error EGL_BAD_CONFIG
[223083:1213/140058.903040:ERROR:gpu_info_collector.cc(77)] gl::GLContext::CreateOffscreenGLSurface failed
[223083:1213/140058.903100:ERROR:gpu_info_collector.cc(378)] Could not create surface for info collection.
[223083:1213/140058.903180:ERROR:gpu_init.cc(82)] CollectGraphicsInfo failed.
[223083:1213/140058.921288:ERROR:viz_main_impl.cc(161)] Exiting GPU process due to errors during initialization
[223106:1213/140059.138358:ERROR:gl_surface_egl.cc(734)] No suitable EGL configs found.
[223106:1213/140059.138490:ERROR:gl_context_egl.cc(286)] eglCreateContext failed with error EGL_BAD_CONFIG
[223106:1213/140059.140446:ERROR:gl_surface_egl.cc(734)] No suitable EGL configs found.
[223106:1213/140059.140522:ERROR:gl_surface_egl.cc(2172)] eglCreatePbufferSurface failed with error EGL_BAD_CONFIG
[223106:1213/140059.140565:ERROR:gpu_info_collector.cc(77)] gl::GLContext::CreateOffscreenGLSurface failed
[223106:1213/140059.140604:ERROR:gpu_info_collector.cc(378)] Could not create surface for info collection.
[223106:1213/140059.140650:ERROR:gpu_init.cc(82)] CollectGraphicsInfo failed.
[223106:1213/140059.141779:ERROR:viz_main_impl.cc(161)] Exiting GPU process due to errors during initialization
[223122:1213/140059.325740:ERROR:sandbox_linux.cc(376)] InitializeSandbox() called with multiple threads in process gpu-process.

[aeschbacher]

I tried to rebuild on another machine, and confirm it still works. Perhaps following is important:

• use current lts version of node (nvm install --lts), currently v16.13.1
• I did not specify any particular version for electron, version returns:

  npx electron-builder --version  
  22.14.5
  

• the change I made to (beautified) app.js is :

# diff -uN ./app-orig/www/app.js ./app/www/app.js
--- ./app-orig/www/app.js	2021-12-13 18:24:32.292944845 +0000
+++ ./app/www/app.js	2021-12-13 18:05:57.257316933 +0000
@@ -37440,6 +37440,7 @@
             build: "1553",
             autofill: "false" != localStorage.autofill,
             autoupgrade: "false" != localStorage.autoupgrade,
+            platform: "linux",
             queue: {
                 loading: !1,
                 pagesize: 200,
@@ -37472,7 +37473,7 @@
             })
         }, f7.checkAppUpdate = function(e) {
             var t;
-            "macOS" == f7.appInfo.platform && (t = "http://upgrade.nadelectronics.com/desktop_app/osx/version.xml?currentVersion"), "Windows" == f7.appInfo.platform && (t = "http://upgrade.nadelectronics.com/desktop_app/windows/version.xml?currentVersion"), f7.request.setup({
+            "linux" == f7.appInfo.platform && (t = "http://upgrade.nadelectronics.com/desktop_app/osx/version.xml?currentVersion"), "macOS" == f7.appInfo.platform && (t = "http://upgrade.nadelectronics.com/desktop_app/osx/version.xml?currentVersion"), "Windows" == f7.appInfo.platform && (t = "http://upgrade.nadelectronics.com/desktop_app/windows/version.xml?currentVersion"), f7.request.setup({
                 cache: !1
             }), f7.request({
                 url: t,

• and for package.json:

# diff -uN app-orig/package.json app/package.json 
--- app-orig/package.json	2021-12-13 18:24:07.365390174 +0000
+++ app/package.json	2021-12-13 18:09:03.697901757 +0000
@@ -19,5 +19,17 @@
     "wifi-control": "^2.0.1",
     "wifi-password": "^3.0.1",
     "xml2js": "^0.4.17"
+  },
+  "build": {
+    "appId": "com.bluos.app",
+    "extraResources": [
+      {
+        "from": "resources",
+        "to": ".",
+        "filter": [
+          "**/*"
+        ]
+      }
+    ]
   }
 }

Perhaps also worth noting I built in a container (to avoid polluting my host) with podman run -it -v $PWD:/src debian:bullseye

[andmarti1424]

Confirmed. Its working properly! Was patching the wrong package.json and not the one inside app folder.
Also, thanks for the instructions on the app.js patch.

[bdavj]

I ended up with a really hacky way around this using the original Mac DMG (as I was hitting the same issue with the build script)

dmg2img BluOS-Controller-3.16.2.dmg BluOS-Controller-3.16.2.img
7z x BluOS-Controller-3.16.2.img

worked for me in the end to generate the folder structure of the original DMG.

[aeschbacher]

I just tried the same method described in the issue with 3.18.4 [1] , and can confirm that it still works with this version.

[1] https://bluos.net/wp-content/uploads/2022/08/BluOS-Controller-Setup-3.18.4.exe