Repository navigation
Harden Aviator FPR XML parsing against XXE - #1123
Merged
rsenden merged 4 commits intoOct 5, 2026
Merged
Conversation
kireetivar
marked this pull request as ready for review
October 1, 2026 10:46
rsenden
merged commit Oct 5, 2026
5e69800
into
fortify:feat/v3.x/aviator/26.4
14 of 15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Secure the correlation XML parsing against XXE while still allowing a real FPR DOCTYPE.
SastFprCorrelationRecorder.parseXmlonly setnamespaceAware; it now blocks external DTDs and entities, andwriteXmlis locked down the same way.disallow-doctype-declstays off soaudit.xmlstill parses.src-archive/index.xmlis already handled inFprHandle(entities and internal subsets rejected; only the Fortify properties DOCTYPE is allowed).src-xrefdata/index.xmlis not parsed. Added tests that aSYSTEMentity is not resolved and a harmless DOCTYPE still parses.Also updated the
--previewoption description.