Skip to content

fix: add resend speakers checkbox on summit speakers email send popup - #1064

Open
tomrndom wants to merge 3 commits into
masterfrom
fix/resend-speakers-checkbox
Open

fix: add resend speakers checkbox on summit speakers email send popup#1064
tomrndom wants to merge 3 commits into
masterfrom
fix/resend-speakers-checkbox

Conversation

@tomrndom

@tomrndom tomrndom commented Sep 4, 2026

Copy link
Copy Markdown

ref: https://app.clickup.com/t/9014802374/86bbtnft1

image

Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com

Summary by CodeRabbit

  • New Features
    • Added the ability to resend emails to speakers and submitters who have already received them.
    • Added a resend confirmation checkbox for both speaker and submitter email modes, enabled by default.
    • The confirmation label now adapts to the selected recipient type.
    • The option to copy emails to submitters remains available only when emailing speakers.
    • Added updated English-language text for resend confirmations.

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
@tomrndom tomrndom self-assigned this Sep 4, 2026
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Review Change Stack

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: bf63ba00-4024-43d2-8b51-a3df52a74cb1

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Essentials

Run ID: cadcba96-f8bf-491f-bc87-d2737aed69fe

📥 Commits

Reviewing files that changed from the base of the PR and between f22484d and ed98c32.

📒 Files selected for processing (4)
  • src/actions/speaker-actions.js
  • src/actions/submitter-actions.js
  • src/i18n/en.json
  • src/pages/summit_speakers/summit-speakers-list-page.js

Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

The speaker email workflow adds a resend-speakers checkbox, passes its value through the page and action layers, and includes it as should_resend in the email request. The submitter email action also accepts the new parameter.

Changes

Speaker email resend

Layer / File(s) Summary
Email action contract
src/actions/speaker-actions.js, src/actions/submitter-actions.js
The email actions accept shouldResendSpeakers. The speaker action sends it as should_resend.
Speaker email resend UI
src/pages/summit_speakers/summit-speakers-list-page.js, src/i18n/en.json
The speaker-only modal adds a default-checked resend checkbox. The selected value passes to the speaker email action with the existing submitter-copy option.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to ed98c

The email confirmation dialog now lets administrators resend messages to already-sent speakers or submitters, and the selected setting is sent with each email request. No current merge-blocking risk remains.

Sequence Diagram(s)

sequenceDiagram
  participant SpeakerEmailModal
  participant SummitSpeakersPage
  participant sendSpeakerEmails
  participant EmailRequest
  SpeakerEmailModal->>SummitSpeakersPage: select resend speakers
  SummitSpeakersPage->>sendSpeakerEmails: submit shouldResendSpeakers
  sendSpeakerEmails->>EmailRequest: send should_resend
Loading

Suggested reviewers: santipalenque, smarcet, romanetar

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding a resend speakers checkbox to the summit speakers email send popup.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/resend-speakers-checkbox

Comment @coderabbitai help to get the list of available commands.

Comment thread src/pages/summit_speakers/summit-speakers-list-page.js Outdated

@smarcet smarcet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomrndom please review

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
@smarcet
smarcet self-requested a review September 7, 2026 19:50
Comment thread src/actions/submitter-actions.js Outdated
Comment thread src/actions/speaker-actions.js Outdated

@smarcet smarcet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomrndom please review

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
@tomrndom
tomrndom requested a review from smarcet September 8, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants