Repository navigation
refactor(nostrand): split the engine out of the CLI into a Nostrand library - #189
Merged
Merged
Conversation
parth-io
marked this pull request as draft
October 5, 2026 09:15
…in SourceLink The runtime and nostrand csprojs ran `git describe` to fill SourceRevisionId. Since SDK 8, SourceLink fills in the full commit SHA itself.
parth-io
force-pushed
the
refactor/split-cli-from-boot
branch
2 times, most recently
from
October 6, 2026 06:36
8acc1fa to
1a68869
Compare
parth-io
marked this pull request as ready for review
October 6, 2026 06:39
parth-io
force-pushed
the
refactor/split-cli-from-boot
branch
from
October 6, 2026 06:48
1a68869 to
443df73
Compare
skydread1
reviewed
Oct 6, 2026
…ibrary (#185) Nostrand.cs held both the engine and the console entry point, so the only way to boot MAGIC was to run the exe. The engine now lives in nostrand-lib/ as Nostrand.dll, and nostrand/ is the CLI wrapper. The terminal tasks moved to a new nostrand.cli, which the CLI registers through Runtime.RegisterTasks. nostrand.repl/repl had no callers and was removed.
parth-io
force-pushed
the
refactor/split-cli-from-boot
branch
from
October 7, 2026 05:36
443df73 to
7c0d887
Compare
skydread1
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #185
Code refactor
NostrandMain.exeintonostrand-lib/(Nostrand.dll) asRuntime.Boot,LoadNostrand,EstablishProjectandRun, which the CLI'sMaincalls.nostrand.core,nostrand.tasks,nostrand.replandnostrand.deps.*move with it and no longer referenceNostrandMainorMono.Terminal, so a host without a console (the Unity Editor) can serve the UDP REPL.version,where,repl*functions) move to a newnostrand.cli.Tweaks made to support the refactor
Runtime.RegisterTasksadds a namespace to the unqualified-name search afternostrand.tasks, so a host cannot shadow a built-in. The CLI registersnostrand.clithis way. The task list andFindFunctionmove fromNostrandintoRuntimebesideRun, so the registry lives in one class.nostrand.repl/sockettakes:on-startand:on-evalcallbacks in place of its console loop and echo, andnostrand.clisupplies both, along with the private helperscontinue-promptandbalanced?.nostrand.repl/replfunction is deleted.Cleanup
nostrand/Scripts/patch-assembly-info.shandunpatch-assembly-info.sh, and drops the customSetSourceRevisionIdtargets from.csprojfiles. Those changes originally addedgit describestrings, but now since SDK 8, SourceLink fills in the full commit SHA itself.