Repository navigation
rfc20: add optional slots key to R_lite entries - #557
Merged
Merged
Conversation
|
|
Problem: RFC 20 does not state that an execution target may appear in only one R_lite entry. This is implied by the one to one mapping of nodelist to R_lite execution targets, and is assumed by existing implementations, but is not specified. State that an execution target MUST NOT appear in more than one R_lite entry. Assisted-by: Claude:opus-5.5
Problem: The execution system needs to know which task slot label the scheduler selected on each execution target, for example to select the matching jobspec tasks entry when a jobspec offers alternative slots. This is currently only available from the opaque, scheduler-specific scheduling key. Add an optional slots dictionary to each R_lite entry that maps task slot labels to a slot count and the resources assigned to those slots. Fixes flux-framework#554 Assisted-by: Claude:opus-5.5
|
|
Contributor
|
Queued — the merge queue status continues in this comment ↓. |
Contributor
Author
|
Thanks! I set MWP |
Contributor
Merge Queue Status
This pull request spent 17 seconds in the queue, including 2 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the suggested
slotskey toR_liteentries in Rv1 as described in this comment in #554.If this is acceptable, we can work on updating the job shell in flux-core to read
slotsand a corresponding mode in the Python schedulers to generate it.