Skip to content

FLEXSIM-12843-FLEXSIM-11184-Fix-Travel-Arrival-Mismatch-For-Home-Location - #23

Merged
surajdesai5000 merged 1 commit into
release/26.0from
bugfix/FLEXSIM-12843-FLEXSIM-11184-Fix-Travel-Arrival-Mismatch-For-Home-Location
Aug 12, 2026
Merged

surajdesai5000 merged 1 commit into
release/26.0from
bugfix/FLEXSIM-12843-FLEXSIM-11184-Fix-Travel-Arrival-Mismatch-For-Home-Location

Conversation

@Shivi-lab

Copy link
Copy Markdown
Collaborator

Issue: With A* enabled, OnResourceAvailable → Travel to Home Location sends the operator toward Source but stops after a few steps. The event list loops on A* ArrivalEvents and Delay task completions. Without A*, travel completes normally.

Root cause: A* treats arrival as “within grid-cell threshold,” while the home picklist still sees distancetotravel > threshold and re-dispatches travel causing an infinite loop.

Fix: In Traveler::onArrival, detect the home picklist pattern (TASKTYPE_TRAVEL followed by TASKTYPE_DELAY(0)). If distancetotravel still exceeds the picklist threshold and the operator is not yet at destLoc, walk a short final leg before completing the travel task.

Fix applies to the standard “Travel to a Home Location” picklist (TRAVEL + DELAY(0)). Custom home-travel task sequences may still need separate handling.

Card: https://autodesk.atlassian.net/browse/FLEXSIM-11184 https://autodesk.atlassian.net/browse/FLEXSIM-12843
Test Model - https://github.com/flexsim-adsk/modules-Testing/pull/26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses an A* “arrival” mismatch that can cause an infinite travel loop when executing the standard “Travel to a Home Location” picklist sequence (TRAVEL followed by DELAY(0)). The change adds logic in Traveler::onArrival to detect that home-travel pattern and, when the picklist still considers the traveler “not arrived,” perform a short final leg to reach destLoc before completing the travel task.

Changes:

  • Detect the “home location” picklist task pattern (TRAVEL → DELAY(0)) during A* arrival handling.
  • If the picklist still sees remaining distance beyond a threshold, initiate a short final-leg navigation toward destLoc and return early.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread AStarDLL/Traveler.cpp
Comment thread AStarDLL/Traveler.cpp

@surajdesai5000 surajdesai5000 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and verified the changes.

@surajdesai5000
surajdesai5000 merged commit f577462 into release/26.0 Aug 12, 2026
2 checks passed
@surajdesai5000
surajdesai5000 deleted the bugfix/FLEXSIM-12843-FLEXSIM-11184-Fix-Travel-Arrival-Mismatch-For-Home-Location branch August 12, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants