FLEXSIM-12843-FLEXSIM-11184-Fix-Travel-Arrival-Mismatch-For-Home-Location - #23
Merged
surajdesai5000 merged 1 commit intoAug 12, 2026
Conversation
Shivi-lab
requested review from
akshay-nangare,
Copilot,
mayanksinha1,
mohammad-ajmal-siddiqui,
pradeepkumar-adsk,
rutuja23-dev,
surajdesai5000 and
vikram-bharti
July 27, 2026 08:06
There was a problem hiding this comment.
Pull request overview
This PR addresses an A* “arrival” mismatch that can cause an infinite travel loop when executing the standard “Travel to a Home Location” picklist sequence (TRAVEL followed by DELAY(0)). The change adds logic in Traveler::onArrival to detect that home-travel pattern and, when the picklist still considers the traveler “not arrived,” perform a short final leg to reach destLoc before completing the travel task.
Changes:
- Detect the “home location” picklist task pattern (TRAVEL → DELAY(0)) during A* arrival handling.
- If the picklist still sees remaining distance beyond a threshold, initiate a short final-leg navigation toward
destLocand return early.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
akshay-nangare
approved these changes
Jul 27, 2026
pradeepkumar-adsk
approved these changes
Jul 28, 2026
surajdesai5000
approved these changes
Aug 12, 2026
surajdesai5000
left a comment
Collaborator
There was a problem hiding this comment.
Tested and verified the changes.
surajdesai5000
deleted the
bugfix/FLEXSIM-12843-FLEXSIM-11184-Fix-Travel-Arrival-Mismatch-For-Home-Location
branch
August 12, 2026 20:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: With A* enabled, OnResourceAvailable → Travel to Home Location sends the operator toward Source but stops after a few steps. The event list loops on A* ArrivalEvents and Delay task completions. Without A*, travel completes normally.
Root cause: A* treats arrival as “within grid-cell threshold,” while the home picklist still sees distancetotravel > threshold and re-dispatches travel causing an infinite loop.
Fix: In Traveler::onArrival, detect the home picklist pattern (TASKTYPE_TRAVEL followed by TASKTYPE_DELAY(0)). If distancetotravel still exceeds the picklist threshold and the operator is not yet at destLoc, walk a short final leg before completing the travel task.
Fix applies to the standard “Travel to a Home Location” picklist (TRAVEL + DELAY(0)). Custom home-travel task sequences may still need separate handling.
Card: https://autodesk.atlassian.net/browse/FLEXSIM-11184 https://autodesk.atlassian.net/browse/FLEXSIM-12843
Test Model - https://github.com/flexsim-adsk/modules-Testing/pull/26