You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was initially concerned that receiving the collateral and starting its cooldown in separate transactions could leave the accounting inconsistent between calls like an additional call may disrupt the accounting. Discussed with @johnnyonline , and both calls are executed atomically through the multisig, so this is not an issue. LGTM
I was initially concerned that receiving the collateral and starting its cooldown in separate transactions could leave the accounting inconsistent between calls like an additional call may disrupt the accounting. Discussed with @johnnyonline , and both calls are executed atomically through the multisig, so this is not an issue. LGTM
Fixed that as well as Schlag's comment about pendingRedemptions may become outdated here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards locked yvUSD market. Market oracle PR @ flexmeow/flex-contracts#24