Repository navigation
chat: drop the Sample client from the chats list - #6
Merged
Merged
Conversation
The Sample client was a scripted conversation partner, in Debug builds only, that answered with every kind of block the chat draws. It put a "Sample" section in the Chats sidebar and a `chat.sample` command in the palette. It has served its purpose, so it goes, with its embedded `sample.png`. The client mechanism it used (`chat.register`, `chat.post`, ...) stays: the agent client and other plugins register through it.
foxnne
marked this pull request as ready for review
October 16, 2026 14:31
This was referenced Oct 16, 2026
foxnne
added this pull request to stack #12
October 16, 2026 14:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #5 (
chat/group-open-state); review that first.What changes
The Chats sidebar no longer shows a Sample section, and the palette no longer has
Open a Sample Chat.
src/Sample.zig(a scripted client, Debug builds only, that answeredwith every kind of block the chat draws) and its embedded
src/sample.pngare removed, alongwith its import and registration in
plugin.zig. Nothing else existed only for it: thecommands it called (
chat.register,chat.open,chat.post,chat.append*,chat.tool,chat.ask,chat.set_plan) are the general client API the agent client and other plugins use,and stay. The README never mentioned it. (The
"sample"client name in aTranscript.zigtestis only test data.)
How it was seen
macOS, Debug fizzy from
mainin a sandbox profile (FIZZY_PROFILE), with anagentclientand two folders of seeded chats, the Chats view opened by a demo tape and the window captured.
Before: Agents (fizzy, website) then a Sample group. After: Agents (fizzy, website) only, no
other change to the tree.
zig fmt --checkclean; the plugin builds.🤖 Generated with Claude Code